SRCH-6454 Remove deprecated ClickCounter, searchgov:promote, and AdvancedSearchesConstraint#2029
Open
luisgmetzger wants to merge 2 commits into
Open
SRCH-6454 Remove deprecated ClickCounter, searchgov:promote, and AdvancedSearchesConstraint#2029luisgmetzger wants to merge 2 commits into
luisgmetzger wants to merge 2 commits into
Conversation
…ncedSearchesConstraint Remove three pieces of deprecated code that depend on i14y/SearchGov engine, which is no longer in use after Phase 1 (SRCH-6428): - ClickCounter service, ClickCounterJob, ClickMonitorJob, and weekly cron schedule entry - searchgov:promote rake task - AdvancedSearchesConstraint (already disconnected from routes) - Associated specs and orphaned test fixtures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes three pieces of deprecated code that depend on i14y / the SearchGov engine, which is no longer in use after Phase 1 completion (SRCH-6428):
ClickCounterJob,ClickMonitorJob, and the weekly cron schedule entry inresque_schedule.ymlsearchgov:promoterake task (manual-only, no longer functional with i14y going away)AdvancedSearchesConstraintclass (already disconnected fromroutes.rb;/search/advancedredirects unconditionally)Also removes orphaned test fixtures and a stale
.rubocop_todo.ymlexclusion.14 files changed, 1 insertion, 872 deletions.
What is NOT removed
click_countfield in OpenSearch (still used for relevancy ranking; spider handles it differently)I14yDocument.promotemodel method (will be cleaned up when i14y is fully decommissioned)searchgov:crawlrake task (separate concern)Deploy notes
ClickMonitorJobcronClickCounterJobentries in the ResquesearchgovqueueNameErroron removed constants for 48 hours post-deployTest plan
ClickCounter,ClickMonitorJob,ClickCounterJob,searchgov:promote,AdvancedSearchesConstraintrake -T searchgovshows onlysearchgov:crawl/search/advancedredirect still worksconfig/resque_schedule.ymlonly hasSitemapMonitorJob