Skip to content

fix(tests): fix unstable tbch tests and failing price threshold test #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shamardy merged 2 commits into from
Oct 11, 2023
Merged

fix(tests): fix unstable tbch tests and failing price threshold test #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffa733e
fix test_trade_preimage_additional_validation test since price thresh…
shamardy Oct 11, 2023
23771b6
add more electrums to unstable tbch address tests
shamardy Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mm2src/coins/utxo/utxo_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,6 +1372,8 @@ fn test_cashaddresses_in_tx_details_by_hash() {
let req = json!({
"method": "electrum",
"servers": [
{"url":"bch0.kister.net:51002","protocol":"SSL"},
{"url":"tbch.loping.net:60002","protocol":"SSL"},
{"url":"electroncash.de:50003"},
{"url":"tbch.loping.net:60001"},
{"url":"blackie.c3-soft.com:60001"},
Expand Down Expand Up @@ -1411,6 +1413,8 @@ fn test_address_from_str_with_cashaddress_activated() {
let req = json!({
"method": "electrum",
"servers": [
{"url":"bch0.kister.net:51002","protocol":"SSL"},
{"url":"tbch.loping.net:60002","protocol":"SSL"},
{"url":"electroncash.de:50003"},
{"url":"tbch.loping.net:60001"},
{"url":"blackie.c3-soft.com:60001"},
Expand Down Expand Up @@ -1449,6 +1453,8 @@ fn test_address_from_str_with_legacy_address_activated() {
let req = json!({
"method": "electrum",
"servers": [
{"url":"bch0.kister.net:51002","protocol":"SSL"},
{"url":"tbch.loping.net:60002","protocol":"SSL"},
{"url":"electroncash.de:50003"},
{"url":"tbch.loping.net:60001"},
{"url":"blackie.c3-soft.com:60001"},
Expand Down
5 changes: 2 additions & 3 deletions mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,11 +1782,10 @@ fn test_trade_preimage_additional_validation() {
assert!(!rc.0.is_success(), "trade_preimage success, but should fail: {}", rc.1);
let actual: RpcErrorResponse<trade_preimage_error::PriceTooLow> = serde_json::from_str(&rc.1).unwrap();
assert_eq!(actual.error_type, "PriceTooLow");
// currently the minimum price is 0.00000001
let price_threshold = BigDecimal::from(1) / BigDecimal::from(100_000_000);
// currently the minimum price is any value above 0
let expected = trade_preimage_error::PriceTooLow {
price: BigDecimal::from(0),
threshold: price_threshold,
threshold: BigDecimal::from(0),
};
assert_eq!(actual.error_data, Some(expected));

Expand Down