(WIP) Save 3D marine analysis - #878
Draft
Dooruk wants to merge 85 commits into
Draft
Conversation
…ive) for obtaining restarts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have this version that works for the marine side as we won't have 4D analyses fields for a while.
For geos_cf and geos_atmos there is additional complexity in terms of:
model/r2d2.pyby definingandictionary forr2d2to refer.So I wanted to check with you @jeromebarre and @mer-a-o, whether you like this approach and would like to build on this, or would like to have a completely different
geos_cfsaveanalysis task? Sorry, I dragged this for a while, wantedSaveForecastto go in first.For the last point (4D fields), I have
swell/src/swell/utilities/geos.py
Lines 423 to 506 in e3007e1
background frequencybut your call.