Fixes for 3dvar_atmos cycling_varbc - #857
Open
mranst wants to merge 15 commits into
Open
Conversation
…me/manstett/swell-main into fix/mranst/cycling_varbc
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few issues related to setting
cycling_varbcto true in3dvar_atmos.flow.cylcis fixed for this option, andGetObsNotInR2d2has been adapted to link previous cycle bias files the same wayGetObservationsdoes.I think there was a bug in the way that previous cycle bias files were linked that has been present for a while. The issue was that when determining the files to link, the process would take the current cycle's bias input file and only replace the cycle directory where it was stored. This would result in the file it was looking for having the wrong background time offset. For example, when running the
20251230T060000Zcycle, the file would start as:It would then only replace the cycle directory, so you would get
When in fact the filename should be:
As this is the
previous cycle timeminusbackground time offsetfor that period, though I could be wrong about how this is supposed to workabi_g16is switched off, as it doesn't look likex0054has observation files for it. Should this normally be a failure state?