3dvar_atmos_cycle has been lost

[rtodling]

At some point we had a suite that cycled the 3dvar atmos analysis, giving the user the opt to cycle the VarBC results from one analysis to the next. It seems to me this got lost when we adopted the more python-oriented version of the suites and redefined the suites to be an explicit python class.

Can we please reinstate the suite?

[mranst]

I looked back at before the PR you're referring to went in, and a bit before that, but couldn't find a 3dvar_atmos_cycle suite. It looks like there's an option cycling_varbc in 3dvar_atmos that does what you're suggesting, though.

swell/src/swell/suites/3dvar_atmos/flow.cylc

Lines 58 to 67 in 69394f0

	# Get observations
	{% if cycling_varbc %}
	# Cycling VarBC is active, biases from the previous cycle will be used
	RunJediVariationalExecutable-{{model_component}}[-PT6H] => GetObsNotInR2d2-{{model_component}}?
	{% else %}
	# Cycling VarBC is inactive, static bias files will be used
	GetObsNotInR2d2-{{model_component}}: fail? => GetObservations-{{model_component}}?
	{% endif %}

Is it possible that these are essentially two suites in one that are controlled by this parameter?

[Dooruk]

@mranst, you are right, there wasn't a suite named like that. This switch also impacts the get_observations task.

Bit of a warning though, this may cause some headache as we skipped R2D2 for x0054 and not work right off the bat.