Restructuring Run routine - #101
pchakraborty wants to merge 3 commits into
Conversation
Pull compute_lw_aer_optics, compute_lw_cloud_optics_mcica, compute_lw_gas_optics, compute_lw_rte, and PROCESS_RRTMGP_LW_BLOCK out of Run/LW_Driver's nested scope into standalone module-level subroutines. Clean up remaining protex double-bang (! !) comment headers to single-bang throughout.
Pull the RADIATIVELY_ACTIVE_AEROSOLS block out of LW_Driver into a standalone module-level compute_provider_aerosol_optics routine, mirroring the MAPL3 port's structure and call site. LW_Driver now just fetches the AERO state and calls the new routine; the AS_FIELD_NAME/AS_PTR_3D/AEROSOL_EXT/AEROSOL_SSA/AEROSOL_ASY/band/ SSA_MAX/ASY_MAX locals move with it and are dropped from LW_Driver's own declarations.
pchakraborty
added
the
0 diff
pchakraborty
added
Contingent - DNA
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, pre-migration-fix, mapl3-readiness, refactor |
5 similar comments
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, pre-migration-fix, mapl3-readiness, refactor |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, pre-migration-fix, mapl3-readiness, refactor |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, pre-migration-fix, mapl3-readiness, refactor |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, pre-migration-fix, mapl3-readiness, refactor |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, pre-migration-fix, mapl3-readiness, refactor |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, pre-migration-fix, mapl3-readiness, refactor |
1 participant
Warning
This PR is contingent on #99 and #100 being merged
Extracted
compute_lw_aer_optics,compute_lw_cloud_optics_mcica,compute_lw_gas_optics,compute_lw_rte, andPROCESS_RRTMGP_LW_BLOCKout ofRun/LW_Driver's nested scope into standalone module-level subroutines.Also extracted the
RADIATIVELY_ACTIVE_AEROSOLSblock out ofLW_Driverinto a standalone module-level compute_provider_aerosol_optics routine, mirroring MAPL3 port's structure and call site.LW_Drivernow just fetches theAEROstate and calls the new routine; the localsAS_FIELD_NAME,AS_PTR_3D,AEROSOL_EXT,AEROSOL_SSA,AEROSOL_ASYetc. move with it and are dropped fromLW_Driver's own declarations.