Skip to content

copy route and issm restarts - #202

Closed
weiyuan-jiang wants to merge 2 commits into
developfrom
feature/wjiang/route_and_issm_rst
Closed

weiyuan-jiang wants to merge 2 commits into
developfrom
feature/wjiang/route_and_issm_rst

Conversation

@weiyuan-jiang

Copy link
Copy Markdown
Contributor

No description provided.

@weiyuan-jiang
weiyuan-jiang requested a review from a team as a code owner September 9, 2026 19:26
Comment thread GEOSldas_App/ldas.py
Comment on lines +464 to +472
#if self.run_route > 0:
# tmpFile=self.ExeInputs['RESTART_ID']+'.route_internal_rst.'+y4m2d2_h2m2
# routeRstFile=self.in_rstdir+'/'+tmpFile
# assert os.path.isfile(routeRstFile), 'route_internal_rst file [%s] does not exist!' %(routeRstFile)

if self.with_issm:
tmpFile=self.ExeInputs['RESTART_ID']+'.issm_internal_rst.'+y4m2d2_h2m2
issmRstFile=self.in_rstdir+'/'+tmpFile
assert os.path.isfile(issmRstFile), 'issm_internal_rst file [%s] does not exist!' %(issmRstFile)
#if self.with_issm:
# tmpFile=self.ExeInputs['RESTART_ID']+'.issm_internal_rst.'+y4m2d2_h2m2
# issmRstFile=self.in_rstdir+'/'+tmpFile
# assert os.path.isfile(issmRstFile), 'issm_internal_rst file [%s] does not exist!' %(issmRstFile)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about the logic here. We get into this block if RESTART=1. In this case, it is expected that the user has provided an LDAS experiment ID, path, & domain that contains a complete set of restarts. At least in the case of RESTART=1, we need to then copy that restart into the (new) experiment directory, just like the catch and landice restarts above

Comment thread GEOSldas_App/ldas.py
Comment on lines +1045 to +1046
if not os.path.isfile(issmRstFile) :
issmRstFile = '/discover/nobackup/projects/gmao/bcs_shared/restarts/surface/issm/v202609/issm_internal_rst'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above. For RESTART=1, we should not backfill from the bcs_shared directory. Backfilling requires spin-up, and that would contradict the instructions encoded here:

print ('# Except for RESTART=1, SPIN-UP is REQUIRED in almost #')

Comment thread GEOSldas_App/ldas.py
Comment on lines +1091 to +1092
routeRstFile = '/discover/nobackup/projects/gmao/bcs_shared/restarts/surface/route/v202605/route_internal_rst.0101_0000'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as comment above

@gmao-rreichle

Copy link
Copy Markdown
Collaborator

Closing after in-person discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants