Repository navigation
Fixes #1548 - eliminate select Turbulence bundles - #1549
Merged
Merged
Conversation
Sync develop into main
Sync develop into main
bena-nasa
added
0 diff
mathomp4
reviewed
Oct 20, 2026
mathomp4
reviewed
Oct 20, 2026
narnold1
approved these changes
Oct 27, 2026
mathomp4
approved these changes
Oct 28, 2026
sdrabenh
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #1548
After discussions with @amolod and @narnold1 we decided it was safe for 4 of the bundles created by physics used to pass information between turbulence and surface to be discarded and the contents (which at the end of the day was 4 fields) could be standard fields and connected as fields that are normally connected.
The reason to eliminate these is that the way these bundles were being created and used is simply not compatible with MAPL3 so this is a PR in preparation for MAPL3.
This change was 0 diff in my testing