Skip to content

Fix gw_intr_ncar call in GWD GC - #1537

Merged
sdrabenh merged 1 commit into
developfrom
bugfix/1535-fix-gwd
Oct 5, 2026
Merged

sdrabenh merged 1 commit into
developfrom
bugfix/1535-fix-gwd

Conversation

@mathomp4

@mathomp4 mathomp4 commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Closes #1535

As found by @pchakraborty The call to gw_intr_ncar in the GC did:

TAUGWX_EAST_TMP, TAUGWY_EAST_TMP, FEGW_EAST_TMP, FEPGW_EAST_TMP, &
TAUGWX_WEST_TMP, TAUGWY_WEST_TMP, FEGW_WEST_TMP, FEPGW_WEST_TMP, &

but the ncar code itself did:

taugwx_east, taugwx_west, taugwy_east, taugwy_west, &
fegw_east, fegw_west, fepgw_east, fepgw_west, &

This wasn't caught by the compiler since they are all the same shape. This PR fixes the GC to do:

TAUGWX_EAST_TMP, TAUGWX_WEST_TMP, TAUGWY_EAST_TMP, TAUGWY_WEST_TMP, &
FEGW_EAST_TMP,   FEGW_WEST_TMP,   FEPGW_EAST_TMP,  FEPGW_WEST_TMP,  &

@mathomp4 mathomp4 self-assigned this Oct 5, 2026
@mathomp4
mathomp4 requested a review from a team as a code owner October 5, 2026 13:03
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 5, 2026
@sdrabenh
sdrabenh merged commit 23e58ba into develop Oct 5, 2026
25 checks passed
@sdrabenh
sdrabenh deleted the bugfix/1535-fix-gwd branch October 5, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GWD: gw_intr_ncar call site passes directional flux arguments in wrong order

2 participants