Skip to content

Use MAPL_StateGetPointer for UV/D_UV_DT bundles in GEOShs_GridComp #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchakraborty merged 1 commit into from
Sep 9, 2026
Merged

Use MAPL_StateGetPointer for UV/D_UV_DT bundles in GEOShs_GridComp #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 9 additions & 35 deletions GEOSagcm_GridComp/GEOShs_GridComp/GEOS_HsGridComp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ module GEOS_HSGridCompMod
use MAPL, only: MAPL_VERTICAL_STAGGER_EDGE
use MAPL, only: MAPL_VERTICAL_STAGGER_NONE
use MAPL, only: MAPL_GridGet, MAPL_GridGetCoordinates
use MAPL, only: MAPL_StateGetPointer, MAPL_FieldBundleGetPointer
use MAPL, only: MAPL_StateGetPointer
use MAPL, only: MAPL_RESTART_SKIP, MAPL_STATEITEM_VECTOR
use MAPL, only: MAPL_Verify, MAPL_Return, MAPL_Assert
use MAPL_Constants, only: MAPL_PI, MAPL_GRAV, MAPL_P00, MAPL_KAPPA, MAPL_RGAS, MAPL_CP
Expand Down Expand Up @@ -207,7 +207,7 @@ subroutine Initialize(gc, import, export, clock, rc)
real, allocatable :: lats(:, :), lons(:, :)
real :: dx, dy, x0, y0, afac, phi0, qmax
! Pointers to internals
#include "HS_DeclarePointer___.h"
#include "HS_DeclarePointer_Internal___.h"
integer :: status

! Get coordinate information
Expand All @@ -218,12 +218,7 @@ subroutine Initialize(gc, import, export, clock, rc)
call MAPL_GridCompGetInternalState(gc, internal, _RC)

! Get pointers to internal variables
! TODO: pchakrab - till ACG bug is fixed
! #include "HS_GetPointer___.h"
call MAPL_StateGetPointer(internal, SPHI2, 'SPHI2' , _RC)
call MAPL_StateGetPointer(internal, CPHI2, 'CPHI2' , _RC)
call MAPL_StateGetPointer(internal, HFCN, 'HFCN' , _RC)
call MAPL_StateGetPointer(internal, P_I, 'P_I' , _RC)
#include "HS_GetPointer_Internal___.h"

! Initialize geometric factors
SPHI2 = sin(lats)**2
Expand Down Expand Up @@ -292,7 +287,6 @@ subroutine Run(gc, import, export, clock, rc)
type(ESMF_State) :: internal
type(ESMF_Grid) :: grid
type(ESMF_Logical) :: friendly
type(ESMF_FieldBundle) :: tmp_bundle

! Pointers to imports/internals/exports
#include "HS_DeclarePointer___.h"
Expand All @@ -302,7 +296,7 @@ subroutine Run(gc, import, export, clock, rc)
! Scratch arrays and working pointers
real, allocatable, dimension(:, :) :: pii, dp, pl, uu, vv, vr, te, f1, rr, ds, dm, pk
real, pointer, dimension(:, :) :: ps, pt
integer :: field_count, level, im, jm, lm, fricq
integer :: level, im, jm, lm, fricq
integer :: i1, in, j1, jn, status
logical :: friendly_temp, friendly_wind
real :: dt, ka, ks, kf
Expand All @@ -322,32 +316,11 @@ subroutine Run(gc, import, export, clock, rc)
call MAPL_GridCompGet(gc, grid=grid, num_levels=lm, _RC)
call MAPL_GridGet(grid, im=im, jm=jm, _RC)

! Pointers to internals
! Pointers to imports/exports/internals
call MAPL_GridCompGetInternalState(gc, internal, _RC)
! TODO: pchakrab - till ACG bug is fixed
! #include "HS_GetPointer___.h"
call MAPL_StateGetPointer(export, DTDT, 'DTDT' , _RC)
! DUDT/DVDT
call ESMF_StateGet(export, "D_UV_DT", tmp_bundle, _RC) ! DUDT/DVDT
call ESMF_FieldBundleGet(tmp_bundle, fieldCount=field_count, _RC)
if (field_count == 2) then ! export bundle is connected
call MAPL_FieldBundleGetPointer(tmp_bundle, 1, dudt, _RC) ! DUDT
call MAPL_FieldBundleGetPointer(tmp_bundle, 2, dvdt, _RC) ! DVDT
end if
call MAPL_StateGetPointer(export, T_EQ, 'T_EQ' , _RC)
call MAPL_StateGetPointer(export, THEQ, 'THEQ' , _RC)
call MAPL_StateGetPointer(export, TAUX, 'TAUX' , _RC)
call MAPL_StateGetPointer(export, TAUY, 'TAUY' , _RC)
call MAPL_StateGetPointer(export, DISS, 'DISS' , _RC)
call ESMF_StateGet(import, "UV", tmp_bundle, _RC) ! U/V
call MAPL_FieldBundleGetPointer(tmp_bundle, 1, u, _RC) ! U
call MAPL_FieldBundleGetPointer(tmp_bundle, 2, v, _RC) ! V
call MAPL_StateGetPointer(import, TEMP, 'TEMP' , _RC)
call MAPL_StateGetPointer(import, PLE, 'PLE' , _RC)
call MAPL_StateGetPointer(internal, SPHI2, 'SPHI2' , _RC)
call MAPL_StateGetPointer(internal, CPHI2, 'CPHI2' , _RC)
call MAPL_StateGetPointer(internal, HFCN, 'HFCN' , _RC)
call MAPL_StateGetPointer(internal, P_I, 'P_I' , _RC)
#include "HS_GetPointer___.h"
call MAPL_StateGetPointer(export, "D_UV_DT", farrayPtr_1=dudt, farrayPtr_2=dvdt, _RC)
call MAPL_StateGetPointer(import, "UV", farrayPtr_1=u, farrayPtr_2=v, _RC)

! Get parameters from the configuration

Expand Down Expand Up @@ -450,6 +423,7 @@ subroutine Run(gc, import, export, clock, rc)
uu = -U(:, :, level) * (f1 * kf)
vv = -V(:, :, level) * (f1 * kf)

! DUDT/DVDT
if (associated(DUDT)) DUDT(:, :, level) = uu
if (associated(DVDT)) DVDT(:, :, level) = vv

Expand Down
Loading