make ISSM GridComp name consistent with LANDICE etc GridComp names for NUM_LDAS_ENSEMBLE>1 - #1510
Merged
Merged
Conversation
weiyuan-jiang
added
the
0 diff
gmao-rreichle
changed the title
…lue consistent with var type (GEOS_ISSMGridComp.F90)
Contributor
|
Testing summary: PR was tested for 1day AMIP, REPLAY and incREPLAY. All were zero diff. Note: PR needed develop branch of GEOSgcm_App with this PR to compile. Not due to this PR but other GCM changes. |
biljanaorescanin
marked this pull request as ready for review
September 1, 2026 16:22
biljanaorescanin
approved these changes
Sep 1, 2026
gmao-rreichle
approved these changes
Sep 1, 2026
sdrabenh
approved these changes
Sep 1, 2026
mathomp4
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Landice (or Land) are run offline in GEOSldas with more than one ensemble member, the children GridComps are named LAND[ICE]_e[xxxx]. This PR makes the name of the ISSM children GridComps consistent with this naming convention.
Minor cleanup of single- vs. double-precision ISSM_DT. Results are non-zero-diff (within "roundoff") for ISSM output.
Also fixed indent of GEOS_ISSMGridComp.F90 (lots of white-space changes).
Regression tests for GCM and LDAS successfully done by @biljanaorescanin on 1 Sep 2026 (#1510 (comment), GEOS-ESM/GEOSldas_GridComp#181)
Related PRs:
GEOS-ESM/GEOSldas_GridComp#181