NAG fixes needed for GEOSldas - #1496
Merged
Merged
Conversation
weiyuan-jiang
added
the
0 diff
gmao-rreichle
added
the
0 diff trivial
Contributor
|
Looks good to me. Topo is also zero diff. I tried c720. |
gmao-rreichle
approved these changes
Aug 26, 2026
gmao-rreichle
marked this pull request as ready for review
August 26, 2026 17:36
gmao-rreichle
approved these changes
Aug 26, 2026
sdrabenh
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bcs preprocessing script to work with NAG compiler.
Trivially 0-diff for GCM and GEOSldas runs.
Zero-diff for make_bcs (tested by @biljanaorescanin on 26 Aug 2026).
This PR depends on