Skip to content

produce tile nc4 file while skipping land params generation - #1495

Draft
weiyuan-jiang wants to merge 7 commits into
developfrom
feature/wjiang/tilenc4_from_til
Draft

produce tile nc4 file while skipping land params generation#1495
weiyuan-jiang wants to merge 7 commits into
developfrom
feature/wjiang/tilenc4_from_til

Conversation

@weiyuan-jiang

Copy link
Copy Markdown
Contributor

No description provided.

@weiyuan-jiang weiyuan-jiang added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 10, 2026
bin/mkLatLonRaster.x -x {NX} -y {NY} -b DE -p PE -t 0 {IMO} {JMO} >/dev/null
bin/CombineRasters.x -f 0 -t {NT} DE{IMO}xPE{JMO} Pfafstetter >/dev/null
bin/CombineRasters.x -t {NT} DC{IM}xPC{JM} DE{IMO}xPE{JMO}-Pfafstetter
setenv OMP_NUM_THREADS 1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have duplicated the computation

@weiyuan-jiang

Copy link
Copy Markdown
Contributor Author

There is nonzero diff for elevation variable. The orignal Nc4 file get raster_id from the memory but the TileFile_ASCII_to_Nc4 reads it from raster file, which leads to nonzero diff

@weiyuan-jiang
weiyuan-jiang marked this pull request as ready for review August 10, 2026 19:04
@weiyuan-jiang
weiyuan-jiang requested a review from a team as a code owner August 10, 2026 19:04
@biljanaorescanin

Copy link
Copy Markdown
Contributor

For me for v14 for these resolutions
CF0180x6C_DE1440xPE0720
CF0180x6C_M6TP1440x1080
CF0540x6C-SG001_CF0540x6C
DC0576xPC0361_DE0360xPE0180
EASEv2_M09
just tile option, so all under geometry, is zero diff.

I also tried option of full run and that works as before.

@weiyuan-jiang did you try to run NL3 and got differences?
Those are different due to compiler when they were created. They are quite old. We can't reproduce those. We even have note about that in the package.

When produced by this code, BCs labeled with 'archived*' below will differ from BCs in archived directories!!! \n \
These differences are caused by compiler changes, code improvements and bug \n \
fixes that were implemented since the archived BCs in the above-mentioned \n \
directories were originally created. The impact of these differences on \n \
science is insignificant, and the parameter files produced by current \n \
code are scientifically equivalent to corresponding archived BCs. \n \
Current code always applies \"mean land elevation fix\" of v13. For v12 and earlier, land elevation produced \n \
by current code thus differs from that in bcs_shared project disk. \n",
"choices": [ \
"NL3 : Icarus-NLv3 (archived*: /discover/nobackup/projects/gmao/bcs_shared/legacy_bcs/Icarus-NLv3/)", \

@weiyuan-jiang

Copy link
Copy Markdown
Contributor Author

@biljanaorescanin @gmao-rreichle I have moved the lake_type to MAPL. So the PR needs this one from MAPL . Also, please note that I changed -9999 to MAPL_UNDEFINED_INTEGER to make it consistent with other integer types. Would this change be acceptable ? @lcandre2

@gmao-rreichle
gmao-rreichle marked this pull request as draft August 20, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. ON HOLD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants