Skip to content

ice_in file for 1/2- and 1/8-deg ocean configuration for mom6-cice6 - #1492

Merged
mathomp4 merged 10 commits into
developfrom
feature/skhani/gcm_v11.10.1
Aug 28, 2026
Merged

ice_in file for 1/2- and 1/8-deg ocean configuration for mom6-cice6#1492
mathomp4 merged 10 commits into
developfrom
feature/skhani/gcm_v11.10.1

Conversation

@sinakhani

@sinakhani sinakhani commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  • ice_in file for new ocean configurations at 1/2-deg and 1/8-deg (720 and 2880 tripolar) is added into cice6_app
  • This PR is mainly for dataatm and coupled runs with MOM6-CICE6
  • This is a 0-diff PR for atm-only setups

@sinakhani
sinakhani requested a review from zhaobin74 August 5, 2026 18:31
@sinakhani
sinakhani requested a review from a team as a code owner August 5, 2026 18:31
@sinakhani sinakhani added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. 0-diff AMIP 0-diff for uncoupled AMIP runs labels Aug 5, 2026
@mathomp4

mathomp4 commented Aug 21, 2026

Copy link
Copy Markdown
Member

@zhaobin74 Are you okay with this?

@zhaobin74

zhaobin74 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@zhaobin74 Are you okay with this?

Not before my comments are addressed.

@sinakhani

sinakhani commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi @zhaobin74. Sorry, I can not see your comments. Please could you point me to your comments. Thank you.

@zhaobin74

zhaobin74 commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @zhaobin74. Sorry, I can not see your comments. Please could you point me to your comments. Thank you.

@sinakhani, I commented 2 weeks ago with some suggested changes. For some reason, github does not show them. Weird.

zhaobin74
zhaobin74 previously approved these changes Aug 21, 2026
View reviewed changes

@zhaobin74 zhaobin74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sinakhani

Comment thread GEOSogcm_GridComp/GEOSseaice_GridComp/CICE_GEOSPlug/cice6_app/2880x2240/ice_in Outdated
Comment thread GEOSogcm_GridComp/GEOSseaice_GridComp/CICE_GEOSPlug/cice6_app/720x576/ice_in Outdated
Comment thread GEOSogcm_GridComp/GEOSseaice_GridComp/CICE_GEOSPlug/cice6_app/2880x2240/ice_in Outdated
Comment thread GEOSogcm_GridComp/GEOSseaice_GridComp/CICE_GEOSPlug/cice6_app/720x576/ice_in Outdated
This was referenced Aug 21, 2026
Merged
Merged
mathomp4
mathomp4 previously approved these changes Aug 26, 2026
View reviewed changes
@sinakhani
sinakhani dismissed stale reviews from mathomp4 and zhaobin74 via 7b81edb August 26, 2026 15:35
@zhaobin74
zhaobin74 self-requested a review August 26, 2026 17:42
zhaobin74
zhaobin74 requested changes Aug 26, 2026
View reviewed changes

@zhaobin74 zhaobin74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinakhani, per our discussion, kstrength in all ice_in should be 0, not 1. Your latest updates changed them to 1. Can you fix? Thanks

@sinakhani

sinakhani commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Oh, sorry! This was because of merging a PR for ocean layout that apparently had an old ice_in setup. I will do a fix. Thank you for catching this, @zhaobin74.

@sinakhani

sinakhani commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

I just updated this including those comments for the 1440x1080/ice_in case.

zhaobin74
zhaobin74 approved these changes Aug 26, 2026
View reviewed changes

@zhaobin74 zhaobin74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@mathomp4 mathomp4 mentioned this pull request Aug 28, 2026
Merged
@mathomp4
mathomp4 merged commit 1a4f8a4 into develop Aug 28, 2026
9 checks passed
@mathomp4
mathomp4 deleted the feature/skhani/gcm_v11.10.1 branch August 28, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes
@zhaobin74 zhaobin74 zhaobin74 approved these changes
@sdrabenh sdrabenh sdrabenh approved these changes

Assignees

No one assigned

Labels

0-diff AMIP 0-diff for uncoupled AMIP runs 0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sinakhani @mathomp4 @zhaobin74 @sdrabenh