Skip to content

Fixes #1482: spurious source of water #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narnold1 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fixes #1482: spurious source of water #1483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91efdec
Fixes spurious source of water from UW by allowing FILL routines to c…
narnold1 Jul 17, 2026
887662d
Limits precip evaporation in GF to avoid negative surface precip
narnold1 Jul 25, 2026
353257b
Merge branch 'develop' into bugfix/narnold1/spurious_water_from_moistgc
narnold1 Jul 30, 2026
c2a8523
Merge branch 'develop' into bugfix/narnold1/spurious_water_from_moistgc
narnold1 Aug 24, 2026
1f91a39
Merge branch 'develop' into bugfix/narnold1/spurious_water_from_moistgc
narnold1 Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/ConvPar_GF2020.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8087,7 +8087,8 @@ SUBROUTINE rain_evap_below_cloudbase(cumulus,itf,ktf, its,ite, kts,kte,ierr,kbco
( sqrt(po_cup(i,k)/psur(i))/alpha2 * prec_flx(i,k+1)/eff_c_conv(i) )**alpha3

!--units here: kg[water]/kg[air}/sec * kg[air]/m3 * m = kg[water]/m2/sec
evap_bcb(i,k)= evap_bcb(i,k)*dp/g
!--Limit to ensure precip is non-negative
evap_bcb(i,k)= min(evap_bcb(i,k)*dp/g,0.9999*(xmb(i)*(pwo(i,k) + edto(i)*pwdo(i,k))+prec_flx(i,k+1)))

else

Expand Down
8 changes: 4 additions & 4 deletions GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/GEOS_UW_InterfaceMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,13 +695,13 @@ subroutine UW_Run (GC, IMPORT, EXPORT, CLOCK, RC)
CLCN(i,j,k) = MAX(0.0, MIN(CLCN(i,j,k) + DQADT_SC(i,j,k)*MOIST_DT, 1.0))

! Add detrained shallow convective ice/liquid source
QLCN(i,j,k) = MAX(0.0, QLCN(i,j,k) + QLDET_SC(i,j,k)*MOIST_DT/MASS(i,j,k))
QICN(i,j,k) = MAX(0.0, QICN(i,j,k) + QIDET_SC(i,j,k)*MOIST_DT/MASS(i,j,k))
QLCN(i,j,k) = QLCN(i,j,k) + QLDET_SC(i,j,k)*MOIST_DT/MASS(i,j,k)
QICN(i,j,k) = QICN(i,j,k) + QIDET_SC(i,j,k)*MOIST_DT/MASS(i,j,k)

! Apply condensate tendency from subsidence, and sink from
! condensate entrained into shallow updraft.
QLLS(i,j,k) = MAX(0.0, QLLS(i,j,k) + (QLSUB_SC(i,j,k)+QLENT_SC(i,j,k))*MOIST_DT)
QILS(i,j,k) = MAX(0.0, QILS(i,j,k) + (QISUB_SC(i,j,k)+QIENT_SC(i,j,k))*MOIST_DT)
QLLS(i,j,k) = QLLS(i,j,k) + (QLSUB_SC(i,j,k)+QLENT_SC(i,j,k))*MOIST_DT
QILS(i,j,k) = QILS(i,j,k) + (QISUB_SC(i,j,k)+QIENT_SC(i,j,k))*MOIST_DT

! Get export QL/QI tendencies
DQLDT_SC(i,j,k) = (QLLS(i,j,k) + QLCN(i,j,k) - DQLDT_SC(i,j,k)) / MOIST_DT
Expand Down