-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fault_proving(compression): glue code for integ into fuel-core #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
982ced3
4c64500
5ab86b4
b7eb652
39ff85c
0a2ea74
6b4fff7
6210a3b
561ace8
ac30df2
d839966
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Swap out off-chain worker compression for dedicated compression service in `fuel-core-bin`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Removed DA compression from off-chain worker in favor of dedicated compression service in `fuel-core-bin`. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| use crate::database::database_description::DatabaseDescription; | ||
| use fuel_core_compression_service::storage::column::CompressionColumn; | ||
| use fuel_core_storage::merkle::column::MerkleizedColumn; | ||
| use fuel_core_types::fuel_types::BlockHeight; | ||
|
|
||
| #[derive(Clone, Copy, Debug)] | ||
| pub struct CompressionDatabase; | ||
|
|
||
| impl DatabaseDescription for CompressionDatabase { | ||
| type Column = MerkleizedColumn<CompressionColumn>; | ||
| type Height = BlockHeight; | ||
|
|
||
| fn version() -> u32 { | ||
| 0 | ||
| } | ||
|
|
||
| fn name() -> String { | ||
| "compression".to_string() | ||
| } | ||
|
|
||
| fn metadata_column() -> Self::Column { | ||
| Self::Column::MerkleMetadataColumn | ||
| } | ||
|
Comment on lines
+21
to
+23
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should have a dedicated metadata column. I had problems trying to use the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Though, since you don't use the metadata table but instead the blocks for the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i don't see the point of having it, the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, though perhaps it's then more correct to set Anyway I agree I'm not worried about this being a production bug, since tests would catch it. I'll approve and let you decide if you want to change the metadata table or not. |
||
|
|
||
| fn prefix(_column: &Self::Column) -> Option<usize> { | ||
| None | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.