Skip to content

Fix opening playlists in external players not working when ignore default args is enabled #8995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
absidue wants to merge 1 commit into
base: development
Choose a base branch
from
+7 −1
Open

Fix opening playlists in external players not working when ignore default args is enabled #8995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/externalPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,13 @@ export async function handleOpenInExternalPlayer(event, payload) {
}

if (ignoreDefaultArgs) {
if (hasValidVideoId) {
if (hasValidPlaylistId && !hasValidVideoId) {
if (typeof cmdArgs.playlistUrl === 'string') {
args.push(`${cmdArgs.playlistUrl}https://youtube.com/playlist?list=${payload.playlistId}`)
} else if (!ignoreWarnings) {
unsupportedActions.push(UnsupportedPlayerActions.OPENING_PLAYLISTS)
}
} else {
Copy link
Copy Markdown
Member

@ChunkyProgrammer ChunkyProgrammer Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the condition?

Suggested change
} else {
} else if (hasValidVideoId) {

args.push(`${cmdArgs.videoUrl}https://www.youtube.com/watch?v=${payload.videoId}`)
}
} else {
Expand Down
Loading