-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Setup playwright tests for accessibility testing #8664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
radmorecameron
wants to merge
7
commits into
FreeTubeApp:development
Choose a base branch
from
radmorecameron:setup-playwright-tests
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5bc8cd7
Setup playwright tests
radmorecameron 59eca06
Run tests in electron, add eslint plugin for playwright
radmorecameron 4079117
change order of imports in eslint config, update clean script to dele…
radmorecameron 62ee366
Use Desktop Chrome instead of Desktop Firefox for viewport config
radmorecameron c287e32
add command line argument to dev-runner to use in-memory database
radmorecameron 017aa4a
Do a separate pack for playwright tests
radmorecameron c5a3eb0
Undo change to dev-runner
radmorecameron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,7 @@ __coverage__ | |
| csak-timelog.json | ||
| .idea/ | ||
| debug/ | ||
| test-results/ | ||
|
|
||
| # Lefthook | ||
| lefthook-local.yml | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
radmorecameron marked this conversation as resolved.
radmorecameron marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| /** @type {import('@playwright/test').PlaywrightTestConfig} */ | ||
| export default { | ||
| testDir: './tests/playwright', | ||
| testMatch: '*.spec.mjs', | ||
| workers: 1, | ||
| fullyParallel: false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { devices, expect, test, _electron as electron } from '@playwright/test' | ||
| import { join } from 'path' | ||
| import { AxeBuilder } from '@axe-core/playwright' | ||
|
|
||
| const mainJs = join(import.meta.dirname, '../../dist/main.js') | ||
|
|
||
| /** | ||
| * | ||
| * @param {string} name | ||
| * @param {import('@playwright/test').ViewportSize} viewPortSize | ||
| * @param {(function({ app: import('@playwright/test').ElectronApplication, page: import('@playwright/test').Page }) : Promise<void>)} func | ||
| */ | ||
| const electronTest = async (name, viewPortSize, func) => { | ||
| // eslint-disable-next-line playwright/expect-expect, playwright/valid-title | ||
| test(name, async () => { | ||
| const electronApp = await electron.launch({ args: [mainJs] }) | ||
| const page = await electronApp.firstWindow() | ||
| page.setViewportSize(viewPortSize) | ||
|
|
||
| await func({ app: electronApp, page }) | ||
|
|
||
| await electronApp.close() | ||
| }) | ||
| } | ||
|
|
||
| /** | ||
| * @param {string} name | ||
| * @param {(function({ app: import('@playwright/test').ElectronApplication, page: import('@playwright/test').Page }) : Promise<void>)} func | ||
| */ | ||
| export const electronDesktopTest = async (name, func) => { | ||
| await electronTest(name, devices['Desktop Chrome'].viewport, func) | ||
| } | ||
|
|
||
| /** | ||
| * @param {string} name | ||
| * @param {(function({ app: import('@playwright/test').ElectronApplication, page: import('@playwright/test').Page }) : Promise<void>)} func | ||
| */ | ||
| export const electronMobileTest = async (name, func) => { | ||
| await electronTest(name, devices['LG Optimus L70'].viewport, func) | ||
| } | ||
|
|
||
| /** | ||
| * @param {string} name | ||
| * @param {(function({ app: import('@playwright/test').ElectronApplication, page: import('@playwright/test').Page }) : Promise<void>)} func | ||
| */ | ||
| export const electronTabletTest = async (name, func) => { | ||
| await electronTest(name, devices['Galaxy Tab S9'].viewport, func) | ||
| } | ||
|
|
||
| /** | ||
| * @param {import('@playwright/test').Page} page | ||
| */ | ||
| export async function validateAccessibility (page) { | ||
| const axeResults = await new AxeBuilder({ page }) | ||
| .setLegacyMode(true) | ||
| .analyze() | ||
|
|
||
| expect(axeResults.violations).toHaveLength(0) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend hiding whitespaces when looking at the changes to this file.
Config was just wrapped in a method that is exported so the IS_TESTS env variable could be set properly: https://webpack.js.org/guides/environment-variables/ (I followed what was in this guide)