Skip to content

Add Parental Control toggle to disable channel link from videos #8502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ozrendev wants to merge 17 commits into
base: development
Choose a base branch
from
Open

Add Parental Control toggle to disable channel link from videos #8502

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1c731e4
add toggle for disable channel link
ozrendev Jan 9, 2026
0497ad0
Merge branch 'development' into toggle-disable-channel-link-video
ozrendev Feb 9, 2026
a7f0b0a
Update src/renderer/store/modules/settings.js
ozrendev Mar 11, 2026
f1d3080
type locale typo
ozrendev Mar 12, 2026
b139c94
remove package-lock.json
ozrendev Mar 12, 2026
74470c8
Merge branch 'development' into toggle-disable-channel-link-video
ozrendev Mar 12, 2026
acbb5c7
remove channel link from watch page
ozrendev Mar 12, 2026
c15d699
change store var to plural
ozrendev Mar 13, 2026
6ddba7a
list video stop using router-link
ozrendev Mar 13, 2026
95d9e9b
we don't need no double negatives ;-)
ozrendev Mar 13, 2026
de2b341
add toggle for playlists
ozrendev Mar 20, 2026
50f7921
add toggle for playlist thumbnail
ozrendev Mar 20, 2026
a90601d
Merge branch 'development' into toggle-disable-channel-link-video
ozrendev Mar 20, 2026
5781438
add toggle for posts
ozrendev Mar 20, 2026
b961704
add toggle for channel thumbnail
ozrendev Mar 29, 2026
c46623f
add conditional component for comments
ozrendev Mar 29, 2026
7034efc
update locales
ozrendev Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/renderer/components/ParentalControlSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
:default-value="showFamilyFriendlyOnly"
@change="updateShowFamilyFriendlyOnly"
/>
<FtToggleSwitch
:label="$t('Settings.Parental Control Settings.Disable Channel Link on Videos')"
compact
:default-value="disableChannelLink"
@change="updateDisableChannelLink"
/>
</div>
<div class="switchColumn">
<FtToggleSwitch
Expand Down Expand Up @@ -59,6 +65,10 @@ const showFamilyFriendlyOnly = computed(() => {
return store.getters.getShowFamilyFriendlyOnly
})

const disableChannelLink = computed(() => {
return store.getters.getDisableChannelLink
})

/**
* @param {boolean} value
*/
Expand Down Expand Up @@ -86,4 +96,11 @@ function updateHideUploader(value) {
function updateShowFamilyFriendlyOnly(value) {
store.dispatch('updateShowFamilyFriendlyOnly', value)
}

/**
* @param {boolean} value
*/
function updateDisableChannelLink(value) {
store.dispatch('updateDisableChannelLink', value)
}
</script>
4 changes: 4 additions & 0 deletions src/renderer/components/ft-list-video/ft-list-video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,10 @@ export default defineComponent({
deArrowCache: function () {
return this.$store.getters.getDeArrowCache[this.id]
},

disableChannelLink: function () {
return this.$store.getters.getDisableChannelLink
},
},
watch: {
showAddToPlaylistPrompt(value) {
Expand Down
5 changes: 5 additions & 0 deletions src/renderer/components/ft-list-video/ft-list-video.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,8 @@
.deArrowToggleIcon {
inline-size: 1em;
}

.linkDisabled {
text-decoration: none;
cursor: initial;
}
3 changes: 2 additions & 1 deletion src/renderer/components/ft-list-video/ft-list-video.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,9 @@
<router-link
v-if="channelId !== null"
class="channelName"
:class="{ 'linkDisabled': disableChannelLink }"
dir="auto"
:to="`/channel/${channelId}`"
:to="!disableChannelLink ? `/channel/${channelId}`: ``"
>
{{ channelName }}
</router-link>
Expand Down
1 change: 1 addition & 0 deletions src/renderer/store/modules/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ const state = {
defaultViewingMode: 'default',
defaultVideoFormat: 'dash',
disableSmoothScrolling: false,
disableChannelLink: false,
Copy link
Copy Markdown
Member

@PikachuEXE PikachuEXE Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this name is quite ambiguous coz I can clearly see channel links in watch page...
Need something more specific

Copy link
Copy Markdown
Contributor Author

@ozrendev ozrendev Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like disableChannelLinkOnVideoThumbnail?

Comment thread
ozrendev marked this conversation as resolved.
Outdated
displayVideoPlayButton: false,
enableSearchSuggestions: true,
enableSubtitlesByDefault: false,
Expand Down
8 changes: 8 additions & 0 deletions static/locales/en-US.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,14 @@ Settings:
Hide Uploader on Watch page: Hide Uploader on Watch page
Show Family Friendly Only: Show Family Friendly Only
Hide Search Bar: Hide Search Bar
Disable Channel Link on Videos : Disable Channel Link on Vidoes
Copy link
Copy Markdown
Member

@PikachuEXE PikachuEXE Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not copy and paste!? (key > value)
Also got the same issue on where does this apply (basically the same as above)

Suggested change
Disable Channel Link on Videos : Disable Channel Link on Vidoes
Disable Channel Link on Videos : Disable Channel Link on Videos

Copy link
Copy Markdown
Contributor Author

@ozrendev ozrendev Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad! Same as above too, Disable Channel Link on Video Thumbnails?

Download Settings:
Download Settings: Download
Ask Download Path: Ask for download path
Choose Path: Choose Path
Download Behavior: Download Behavior
Download in app: Download in app
Open in web browser: Open in web browser
Comment on lines +675 to +681
Copy link
Copy Markdown
Member

@PikachuEXE PikachuEXE Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna guess this is from merging dev...?

Copy link
Copy Markdown
Contributor Author

@ozrendev ozrendev Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I believe so

Copy link
Copy Markdown
Member

@absidue absidue Apr 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this came from a merge, the fact that it is still here means the merge wasn't clean and as those download strings no longer exist on the development branch, merging this pull request as is would add those strings back.

Experimental Settings:
Experimental Settings: Experimental
Warning: These settings are experimental, they may cause crashes while enabled. Making backups is highly recommended. Use at your own risk!
Expand Down