Repository navigation
feat: Allow for this run — run-scoped approval; supervised run finishes the pipeline with far fewer approvals - #43
Merged
Conversation
A run that writes a dozen files asked a dozen times, with only Allow once and Reject on offer. Add a third decision on write/edit asks raised by a gatePolicies rule: one click releases that ask, the other pending asks for the same tool in the same run, and later asks for it. Scoped so it cannot become allow-always: per run (agent id), per tool, in memory only, policy asks only (a critical-signal ask still reaches a human), and never bash. The server re-checks the ask, so a forged request for a bash ask is a 400 and grants nothing. The option is read by id, not by its borrowed allow-always kind. The standalone dashboard page serves a legacy assets/dashboard.js that the current build no longer produces, so it gets the server behaviour but not the button; the in-app Feature Loop page (client.js) does.
…vals
Found by driving a real run through the web UI under gateMode: ask.
The loop never left research. The pipeline's sandbox descriptor was attached
only under YOLO, so every phase gate, the "you stopped early" nudge and ship
returned at "no sandbox" with nothing in the log. It now attaches in every
mode; the containment root stays YOLO-only.
Ship committed nothing under ask (writes were only recorded under YOLO) yet
reported "committed". Requested writes are now recorded, and ship stages only
paths that exist. A repository with no remote is a local project, not a failed
push: ship commits, records the verified sha, and the gate accepts it. A
configured remote that rejects the push still blocks.
The test gate passed an exit 0 from a runner that ran nothing ("[no test
files]"), so ship committed without tests. It now fails that.
A run that reached `done` was recorded as `blocked`, because the pre-step guard
refuses the step after it; the outcome is now goal-met.
Approvals: 24 clicks in the first three minutes of research, almost all
harmless. todo_write / web_search / web_fetch are built-in reads (spec still
overrides; other unknown tools stay irreversible). A strictly read-only bash
runs unprompted under ask (src/shell-readonly.ts: no redirect, substitution,
variable, ~, .., absolute path outside the run, secret file, find -exec,
sort -o, git -c ...), and so do the pieces of the configured verify command.
`deny` mode is unchanged.
Approval card: shows the call (command / path / task) in its own block, drops
the model-facing boilerplate and the "brief unavailable" note, and the
"Approval required" label is readable on a light theme.
Not included: CHANGELOG and the workers files, which carry unrelated edits.
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
tsc --noEmitcleanbash .githooks/pre-commit --allexits 0