fix: the command name is not part of the goal, and a report must name the ref it used - #36
Merged
Merged
Conversation
… the ref it used Driving `/product` end to end for the first time — a live run walked research → prd → implement → test → ship and produced: feat: /product a slugify(text) function that lowercases text and joins its wo… The goal a user typed is not "slash product a slugify". The composer submits a command's return value as the turn with the command name still attached, and everything downstream names work after the goal — branch, commit subject, PR title. Both launchers are now peeled, in order: the app name (`headless …`) and then the command name. A bare `/product` with nothing after it has no goal. That falls through to the deployment's goal rather than naming the run after the command, which is what would otherwise put `/product` in a commit subject and a branch name. And the ship line was reporting the wrong branch. The branch is re-derived at ship time from the session log, but the diagnostic printed `sandbox.branch`, which is the value captured back at containment time — so it announced `fl/create-tmp-fl-headless-proof-txt-contain-run` while the work landed on `fl/a-slugify-text-function-that-lowercases-run`. One value is now used for both the work and the report. A report that names the wrong ref is worse than no report: it reads as a fact. 682 unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #35, which added
/product./producthad unit tests and had never been driven. This is what running it found.The command name is not part of the goal
The composer submits a command's return value as the turn with the command name still attached. Everything downstream names work after the goal — branch, commit subject, PR title — so the slash command went into a commit message.
Both launchers are peeled now, in order: the app name (
headless Say OK.) and then the command name. A bare/productwith nothing after it has no goal, and falls through to the deployment's goal rather than naming the run after the command.A report that named the wrong branch
The branch is re-derived at ship time from the session log — that fix is in #33. But the diagnostic printed
sandbox.branch, which is the value captured back at containment time:One value now feeds both the work and the report. A report naming the wrong ref is worse than no report: it reads as a fact, and this one was confidently wrong for three rounds of diagnosis in the round before it was written.
Proven end to end
682 unit tests pass (679 at #35).