Sisyphus revision: Cache the wiki leak#194
Closed
Reqrefusion wants to merge 5 commits intoFreeCAD:mainfrom
Closed
Conversation
Update wiki.php Update wiki.php [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
Author
|
Not the other one, but I'm closing this PR. I think the other one has more advantages and this PR has turned into a completely different project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@FEA-eng 's misunderstanding brought this idea to my mind. According to this idea, the received files are stored for 24 hours. This can be changed if desired. Accepting or not accepting such a thing is a matter of choice. If it is always wanted to be up to date, this is not used. Also, using such a system with low values is dysfunctional, I think the smallest possible value is one day. It is better not to use it at all instead of a value below it.
This is the first time I try to make a PR to a PR, so I am not sure. You can look at the last commit. This PR adds to that #192 . The aim is to open a discussion because I don't think this is really necessary.