Repository navigation
Conversation
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
download_model()builds the destination path and then creates a directory at the file path:mkdirsucceeds, the followingopen()always fails (IsADirectoryErroron POSIX,PermissionErroron Windows) and onlyrequests.HTTPErroris handled, so the exception escapes. If the directory already exists from an earlier attempt, theif not file_path.exists()guard silently skips the transfer and returns the directory path instead of weights.Its only caller,
android_ext_env.load_cv_model(), feeds the return value intoload_model(), so the GroundingDINO weights can never be downloaded.Fix
Create
file_path.parentinstead offile_path.Tests
tests/metagpt/utils/test_common.py::test_download_model(streamed response stubbed):