SDKS-4801 by tsdamas · Pull Request #27 · ForgeRock/ping-react-native-sdk

tsdamas · 2026-03-26T22:45:32Z

JIRA Ticket

SDKS-4801: Address CI failures and refactor logger integration

Description

Removes configureLogger from the public API and simplifies the logger integration contract across all SDK packages. Key changes:

Dropped nativeLogger/nativeHandle fields from all package config types (storage, journey, oidc, browser, device-profile)
Removed configureLogger from the sample app, integration tests, and docs
Updated native Android/iOS logger integration in browser and device-profile
Added/fixed tsconfig.build.json across all packages to resolve rn-types path alias to built declarations, preventing typecheck errors on cold rebuilds
Added ^build to turbo.json typecheck dependencies to ensure packages are built before typechecking
Migrated RNPackagesTests Xcode scheme from PingSampleApp to PingTestRunner
Excluded lib/ from Jest haste map in all package configs
Updated Mend SAST config for private repo compatibility

Note

For reviewers: The diff is large but the majority of changes across PingSampleApp and package source files are automated Prettier and ESLint formatting fixes (quote style, trailing commas, spacing, semicolons). Focus review effort on the logical changes in packages/logger/src/, the config type deletions across each package's types/ folder, and the tsconfig.build.json additions.

Checklist:

I ran all unit tests and they pass

…stance type

…eScript compatibility

github-actions · 2026-03-27T17:19:45Z

PR Preview Action v1.8.1
🚀 View preview at https://ForgeRock.github.io/ping-react-native-sdk/docs-preview/pr-27/
Built to branch `gh-pages` at 2026-04-09 21:04 UTC. Preview will be ready when the GitHub Pages deployment is complete.

….json. Override the @ping-identity/rn-types path alias in tsconfig.build.json for all packages to use lib/typescript/src/index instead of the source path. This prevents TS6059 rootDir errors when the types package cache is busted and packages rebuild from scratch.

…tern

…estRunner

…pecheck

…kages are built before PingSampleApp typechecks and remove mend sast configExternalUrl for private repo compatibilitty

…e mismatch

pingidentity-gaurav · 2026-04-06T13:25:20Z

Looks like a build artifact. Do we need to commit .map files?

Good catch, no, those files don’t need to be committed. They were generated build artifacts that slipped into the PR. I’ll clean them up and update the ignore rules if needed.

pingidentity-gaurav · 2026-04-06T17:27:17Z

LGTM

rodrigoareis

Overall changes looks good. Left some minor comments.

rodrigoareis · 2026-04-08T00:49:02Z


 /**
 * Cached default logger used when callers do not provide one.
 */
 let defaultLoggerInstance: LoggerInstance | null = null;

 const createNoopLogger = (): LoggerInstance => ({
-  nativeHandle: { id: "native-none-id" },
+  nativeHandle: { id: 'native-none-id' },


It seems the storage module is not aligned with other packages changes. It was not updated to match the simplified noop pattern used in browser, device-profile, journey, and oidc.

rodrigoareis · 2026-04-08T01:03:30Z

  return { module, nativeLogger, sdkLogger };
 };

 describe('logger package', () => {
-  it('configureLogger registers a native logger and returns a handle', async () => {


These tests for configureLogger were removed. But since configureLogger is still called internally by logger(), the error path — where registerLogger returns an empty string — is no longer tested.

Also, now it's missing test for default log level.

rodrigoareis · 2026-04-08T01:08:38Z

@@ -26,5 +26,6 @@
    "strict": true,
    "target": "ESNext",
    "verbatimModuleSyntax": true
-  }
+  },
+  "exclude": ["lib"]


Suggested change

"exclude": ["lib"]

"exclude": ["lib", "**/__tests__/**"]

rodrigoareis · 2026-04-08T01:09:10Z

@@ -26,5 +26,6 @@
    "strict": true,
    "target": "ESNext",
    "verbatimModuleSyntax": true
-  }
+  },
+  "exclude": ["lib"]


Suggested change

"exclude": ["lib"]

"exclude": ["lib", "**/__tests__/**"]

rodrigoareis · 2026-04-08T01:09:44Z

+      "@ping-identity/rn-journey": ["./src/index"],
+      "@ping-identity/rn-types": ["../types/lib/typescript/src/index"]
+    }
+  },
  "exclude": ["example", "lib"]


Suggested change

"exclude": ["example", "lib"]

"exclude": ["lib", "**/__tests__/**"]

rodrigoareis · 2026-04-08T01:27:37Z

@@ -4,7 +4,8 @@
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */
-/* eslint-env jest */
+
+import packageJson from '@ping-identity/rn-logger/package.json';

 export {};


I think it can be removed, the file has a top-level import packageJson

rodrigoareis · 2026-04-08T01:28:20Z

 * - Handles native errors gracefully
 */

+export {}


Suggested change

export {}

export {};

rodrigoareis · 2026-04-08T01:28:32Z

 * - Propagates native errors to callers
 */

+export {}


Suggested change

export {}

export {};

rodrigoareis · 2026-04-08T01:28:41Z

 * - Propagates native errors to callers
 */

+export {}


Suggested change

export {}

export {};

rodrigoareis · 2026-04-08T01:28:48Z

 * - dispose() cleans up the native instance
 */

+export {}


Suggested change

export {}

export {};

rodrigoareis

LGTM

tsdamas added 7 commits March 26, 2026 10:11

fix: update Mend SAST configExternalURL to use HTTPS raw GitHub URL

29ec210

fix(browser): disable eslint failure for certain empty object rules

9152df4

fix(storage): cast logger through unknown in test to satisfy LoggerIn…

4f7ac81

…stance type

fix(sample-app): replace global with globalThis in HomeScreen for Typ…

14033c2

…eScript compatibility

fix(sample-app): force legacy eslint config for lint

520f7af

Fix workspace type resolution for rn-types during package typecheck

bc20af3

Remove docs from root

b7cf720

tsdamas changed the title ~~SDKS-4556 (do not review)~~ SDKS-4556 WIP Mar 27, 2026

tsdamas added 20 commits March 27, 2026 14:35

feat(logger): remove configureLogger from public API

e0bb041

fix(types: update types doc to remove configurelogger

38e4c5c

fix(storage): remove nativeLogger field

5d93262

fix(oidc): remove nativeLogger:NativeLoggerHandle field

7b414dd

fix(journey): remove nativeLogger:NativeLoggerHandle field

5739d15

fix(dvc-profile): remove nativeLogger:NativeLoggerHandle field

a3bee63

fix(dvc-id): remove configureLogger from docs

d5438a5

fix(browser): remove nativeHandle:NativeLoggerHandle field

0976c9b

fix(integration): remove configureLogger from logger integration tests

69b590a

fix(jest): exclude lib/ from haste map in all package jest configs

54294c5

fix(sample-app): remove logger configure step from sample app

6f7f01a

chore(browser): align logger integration with new contract pattern

aa9e043

chore(device-profile): align logger integration with new contract pat…

2dd82b6

…tern

chore(browser): update native side to new logger contract

6009c36

chore(logger): remove remaining mend findings

a60a3f2

feat(ios): migrate RNPackagesTests scheme from PingSampleApp to PingT…

d67c9bc

…estRunner

fix(PingTestRunner): add paths and scenarios to tsconfig to fix CI ty…

4eb32e7

…pecheck

fix(turbo): add ^build to typecheck dependsOn to ensure workspace pac…

d42605f

…kages are built before PingSampleApp typechecks and remove mend sast configExternalUrl for private repo compatibilitty

fix(storage): fix prettier formatting in index.tsx and storage.types.ts

707e6d2

tsdamas changed the title ~~SDKS-4556 WIP~~ SDKS-4801 Mar 31, 2026

tsdamas requested review from pingidentity-gaurav and rodrigoareis March 31, 2026 15:47

tsdamas added 2 commits March 31, 2026 09:22

fix(ci): remove DerivedData restore-keys to prevent Clang module mtim…

57f30c1

…e mismatch

fix(ci): fix module cache reset step ordering and path resolution

ac7c9ea

pingidentity-gaurav reviewed Apr 6, 2026

View reviewed changes

chore(types): remove tracking generated declarations in src

ad7cdc8

pingidentity-gaurav approved these changes Apr 6, 2026

View reviewed changes

rodrigoareis requested changes Apr 8, 2026

View reviewed changes

tsdamas added 2 commits April 8, 2026 13:49

chore(SDKS-4801): addressing review comments

220b1af

chore(SDKS-4801): add missing semicolon to device-id integration test

a653495

rodrigoareis approved these changes Apr 9, 2026

View reviewed changes

fix(logger): correct prettier formatting in logger test

61259b3

tsdamas merged commit 070940d into main Apr 9, 2026
7 of 10 checks passed

tsdamas deleted the SDKS-4556 branch April 9, 2026 21:42

	"exclude": ["example", "lib"]
	"exclude": ["lib", "/__tests__/"]

Conversation

tsdamas commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JIRA Ticket

Description

Checklist:

Uh oh!

github-actions Bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-04-09 21:04 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsdamas Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pingidentity-gaurav commented Apr 6, 2026

Uh oh!

rodrigoareis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodrigoareis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

tsdamas commented Mar 26, 2026 •

edited

Loading

github-actions Bot commented Mar 27, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-04-09 21:04 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

tsdamas Apr 6, 2026 •

edited

Loading