Skip to content

feat(GitLab): Browse GitLab issues and merge requests (frontend)#7273

Merged
emyller merged 11 commits intomainfrom
feat/gitlab-browse-frontend
Apr 20, 2026
Merged

feat(GitLab): Browse GitLab issues and merge requests (frontend)#7273
emyller merged 11 commits intomainfrom
feat/gitlab-browse-frontend

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented Apr 17, 2026 •
edited
Loading

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #7160

Stack: #7270 (backend) → #7273 (this) → #7274 (linking)

With the backend proxy endpoints in place (#7270), the frontend can now let users browse their GitLab projects, issues, and merge requests directly from the feature flag Links tab.

How to review

  • Start from the Links tab wiring in modals/create-feature/index.tsx.
  • GitLabLinkSection and GitHubLinkSection are siblings.

Review effort: 2/5

How did you test this code?

Manual UI testing. Screenshots:

image image image image image

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 17, 2026 11:39pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 17, 2026 11:39pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 17, 2026 11:39pm

Request Review

@emyller emyller mentioned this pull request Apr 17, 2026
Merged
4 tasks
@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Apr 17, 2026
@github-actions github-actions Bot added the feature New feature or request label Apr 17, 2026
@emyller emyller mentioned this pull request Apr 17, 2026
Merged
4 tasks
@emyller emyller changed the title feat(GitLab): Browse GitLab issues and MRs (frontend) feat(GitLab): Browse GitLab issues and MRs from the feature modal Apr 17, 2026
@emyller emyller changed the title feat(GitLab): Browse GitLab issues and MRs from the feature modal feat(GitLab): Browse GitLab issues and merge requests (frontend) Apr 17, 2026
@emyller emyller marked this pull request as ready for review April 17, 2026 00:48
@emyller emyller requested a review from a team as a code owner April 17, 2026 00:48
@emyller emyller requested review from talissoncosta and removed request for a team April 17, 2026 00:48
claude[bot]
claude Bot reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7273 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7273 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7273 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7273 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7273 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7273 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  24.5 seconds
commit  8075549
info  🔄 Run: #16157 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  10.5 seconds
commit  8075549
info  🔄 Run: #16157 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  52 seconds
commit  8075549
info  🔄 Run: #16157 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 4 seconds
commit  8075549
info  🔄 Run: #16157 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.8 seconds
commit  c4a4307
info  🔄 Run: #16178 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  29.5 seconds
commit  c4a4307
info  🔄 Run: #16178 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  58.2 seconds
commit  c4a4307
info  🔄 Run: #16178 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  47.4 seconds
commit  c4a4307
info  🔄 Run: #16178 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

Zaimwa9
Zaimwa9 requested changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Couple of comments, the encodeURIComponent is the one worth fixing while we are at it. Ideally the error message in the Select.

I allowed myself a couple of less important and style comments that could be tackled at the same time.

And whether you want to use a flag

Comment thread frontend/common/services/useGitlab.ts Outdated
Comment thread frontend/common/services/useGitlab.ts Outdated
Comment thread frontend/web/components/GitHubLinkSection.tsx Outdated
Comment thread frontend/web/components/GitLabProjectSelect.tsx Outdated
Comment thread frontend/web/components/GitLabSearchSelect.tsx Outdated
Comment thread frontend/web/components/GitLabProjectSelect.tsx Outdated
Comment thread frontend/common/hooks/useHasGitLabIntegration.ts
talissoncosta
talissoncosta reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid review from @Zaimwa9

Agree with all of it. Just adding a few small points on top, just to prevent the any's to spread around.

Comment thread frontend/common/services/useGitlab.ts Outdated
Comment thread frontend/web/components/GitHubLinkSection.tsx Outdated
Comment thread frontend/web/components/GitLabLinkSection.tsx Outdated
Base automatically changed from feat/gitlab-link-issues-mrs to main April 17, 2026 17:18
@emyller emyller requested a review from a team as a code owner April 17, 2026 17:18
@emyller emyller requested review from Zaimwa9 and removed request for a team April 17, 2026 17:18
@github-actions github-actions Bot added the feature New feature or request label Apr 17, 2026
@github-actions github-actions Bot removed the feature New feature or request label Apr 17, 2026
@github-actions github-actions Bot added the feature New feature or request label Apr 17, 2026
@emyller emyller force-pushed the feat/gitlab-browse-frontend branch from f48050b to ed874d6 Compare April 17, 2026 23:27
@github-actions github-actions Bot removed the feature New feature or request label Apr 17, 2026
@github-actions github-actions Bot added the feature New feature or request label Apr 17, 2026
@github-actions github-actions Bot removed the feature New feature or request label Apr 17, 2026
@github-actions github-actions Bot added the feature New feature or request label Apr 17, 2026
@emyller emyller marked this pull request as ready for review April 17, 2026 23:42
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026
@emyller
Copy link
Copy Markdown
Contributor Author

emyller commented Apr 17, 2026

Thanks for such a great review @Zaimwa9 and @talissoncosta, and for the patience guiding me through 2026 frontend land! All comments addressed — please resolve each thread, or respond with advice. Thanks in advance.

@emyller emyller requested a review from talissoncosta April 17, 2026 23:45
Zaimwa9
Zaimwa9 reviewed Apr 18, 2026
View reviewed changes
Comment thread frontend/web/components/GitLabLinkSection.tsx
Zaimwa9
Zaimwa9 approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve on my side, leaving Talisson give the final approval 👍

@emyller emyller merged commit cf2ed8d into main Apr 20, 2026
44 checks passed
@emyller emyller deleted the feat/gitlab-browse-frontend branch April 20, 2026 15:18
@flagsmithdev flagsmithdev mentioned this pull request Apr 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@talissoncosta talissoncosta talissoncosta approved these changes

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes

Assignees

No one assigned

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emyller @talissoncosta @Zaimwa9