fix: config set support object value#1123
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
openspec config set workflows '["propose","explore","new","continue","apply","ff","sync","archive","bulk-archive","verify","onboard"]' Error: Invalid configuration - workflows: Invalid input: expected array, received string |
alfred-openspec
left a comment
There was a problem hiding this comment.
This is the right UX direction, but it needs the command metadata and tests before merge. config set --json is not added to src/core/completions/command-registry.ts, so completions/metadata will miss the new flag, and this config-writing path should have focused tests for JSON arrays/objects, invalid JSON, --string conflict, validation failure, output formatting, and no mutation on error.
Summary by CodeRabbit
New Features
config setgains a--jsonflag to parse values as JSON.--allow-unknownflag to bypass key-path validation.Improvements
--stringand--json.