You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The open PRs for an rc2 and the order in which they merge cleanly, smallest and most isolated first. This list used to live in a comment on #302; it is kept up to date here as PRs open and merge.
Driver-code hunks do not overlap between independent PRs, with one adjacent-line exception: #314 and #311 each add a member after rowNumberParamArray in OdbcStatement.h, so whichever lands second needs a one-line rebase. Otherwise: #308 shares OdbcDesc.cpp with #303 and OdbcStatement.cpp with #304, in different functions; #310, #311 and #313 change executeStatementParamArray in sequence, which nothing else touches; #315 changes the fetch path, which nothing else touches; #314 adds a case fifty lines from the block #304 adds; #314 and #317 change sqlGetDescField in sequence; #317's sqlColAttribute hunk is in a function nothing else touches. Shared files on the test side: #292 and #302 both add helpers to test_param_conversions.cpp; #303, #304 and #305 each add a line to tests/CMakeLists.txt; #303, #305 and #315 extend test_block_cursor.cpp in sequence; #308, #310, #311 and #313 extend test_array_binding.cpp in sequence; #314 and #317 extend test_descriptor.cpp in sequence, and #314 alone touches test_scrollable_cursor.cpp. Whichever lands later gets a rebase from me the same day.
Every open issue reported this month has a PR above.
The open PRs for an rc2 and the order in which they merge cleanly, smallest and most isolated first. This list used to live in a comment on #302; it is kept up to date here as PRs open and merge.
OdbcDesc.cpp(setDefaultImplDesc), plus a regression test. Fixes SQLPrepare discards SQL_ATTR_ROWS_FETCHED_PTR and SQL_ATTR_ROW_STATUS_PTR set before it, so block cursors never learn how many rows a fetch returned #301.caselines insqlGetStmtAttr(OdbcStatement.cpp), plus a round-trip test.fetchData, its static-cursor twin andreturnDataFromExtendedFetch. Fixes Column-wise binding with SQL_ATTR_ROW_BIND_OFFSET_PTR writes every row of a rowset to the same address #306.SQL_ATTR_KEYSET_SIZEkept apart from the rowset size,HY007for an unprepared IRD; three commits on master. Fixes SQL_ATTR_KEYSET_SIZE overwrites the rowset size; SQLGetDescField on an unprepared IRD answers HY091 instead of HY007 #307.OdbcDesc.cpp,OdbcDesc.h,sqlColAttributeinOdbcStatement.cppand the two SQLColAttribute entry points inMain.cppandMainUnicode.cpp. Fixes Implementation descriptors: records empty until the first bind or execute, raw type fields, 32-bit length writes; SQLColAttribute type fields #316.bindInputOutputParam,sqlExecute/sqlExecDirectandgetConciseSize. Fixes Parameter arrays: fixed-length C types use BufferLength as the element stride, so every row receives element 0 (silent data corruption) #299.SQL_ATTR_PARAM_OPERATION_PTR, stacked on Fix column-wise parameter arrays reading element 0 for fixed-length C types (#299) #308; two commits, one function.SQLRowCountafter an array execute, stacked on Honour SQL_ATTR_PARAM_OPERATION_PTR in parameter-array execution #310; two commits.SQL_C_GUIDparameter binding, all review notes addressed. Fixes SQL_C_GUID parameter binding sends corrupted data on the wire (Phase 8 / T5-5) #295.All thirteen are green on the full matrix.
Driver-code hunks do not overlap between independent PRs, with one adjacent-line exception: #314 and #311 each add a member after
rowNumberParamArrayinOdbcStatement.h, so whichever lands second needs a one-line rebase. Otherwise: #308 sharesOdbcDesc.cppwith #303 andOdbcStatement.cppwith #304, in different functions; #310, #311 and #313 changeexecuteStatementParamArrayin sequence, which nothing else touches; #315 changes the fetch path, which nothing else touches; #314 adds acasefifty lines from the block #304 adds; #314 and #317 changesqlGetDescFieldin sequence; #317'ssqlColAttributehunk is in a function nothing else touches. Shared files on the test side: #292 and #302 both add helpers totest_param_conversions.cpp; #303, #304 and #305 each add a line totests/CMakeLists.txt; #303, #305 and #315 extendtest_block_cursor.cppin sequence; #308, #310, #311 and #313 extendtest_array_binding.cppin sequence; #314 and #317 extendtest_descriptor.cppin sequence, and #314 alone touchestest_scrollable_cursor.cpp. Whichever lands later gets a rebase from me the same day.Every open issue reported this month has a PR above.