feat(manufacturers): add manufacturer logo support#28
feat(manufacturers): add manufacturer logo support#28akira69 wants to merge 3 commits intoFire-Devils:develfrom
Conversation
|
I'll check this later, because i'm working on a database for manufacturers and brands, wo send his data, logo, spools etc to a dataset. this will be implemented to filaman. |
|
@ManuelW77 I should have written a discussion point, my intention was to later provide an import action via plug-in using this GitHub repo: https://github.com/MarksMakerSpace/filament-profiles Maybe you don't need to repeat this work of maintaining a database. Or you can use this as a basis and fork from it. I did a whole bunch of work for spoolman including exactly this, but I can't get traction there. You've already been 100x more receptive! Looking forward to help add features! I did that work at Donkie/Spoolman/pull/872 here's a video of that sync action working
--> this would work well as a plugin I think. |
|
Thanks for your work but brand logos are included since 1.2.0 in an other way. |

Summary
Adds manufacturer logo support to FilaMan as a standalone PR based on
main, independent from the export and printing branches.This PR adds backend logo storage/import/clear support, serves stored manufacturer logo files, exposes the new manufacturer logo fields in API responses, and surfaces manufacturer logos across the manufacturers, filament, and spool UI.
Logos are handled as copied local assets. Remote URLs are used only as transient import sources and are not persisted as manufacturer state. The upload/import pipeline validates supported image formats, enforces a bounded file size, and uses safer remote fetch handling before storing the asset locally.
Base / Branch Context
Fire-Devils/filaman-systemmainakira69:fd/pr4-manufacturer-logosWhy
Implementation
gradientmulti-color style renders horizontal bandsstripedmulti-color style renders vertical bandsCode Quality / Validation
backend/.venv/bin/python -m compileall appcp ../version.txt ./version.txt && npm run build && rm -f ./version.txtbackend/.venv/bin/python -m pytest tests/test_filaments.pybackend/.venv/bin/python -m pytest tests/test_filaments.py -k 'logo'Test Checklist
...The spool edit change-preview interaction remains unchecked because the available seeded spool fixture only exposed one filament option during live verification.
Screenshots
Manufacturer overview with real logos
Manufacturer modal upload preview
Filament detail hero
Filament edit manufacturer preview
Spool detail hero, striped multi-color
Spool detail hero, gradient multi-color
Spool edit manufacturer preview