Skip to content

ci-3692 inset vertical videos#176

Open
leannecornish-ft wants to merge 1 commit into
mainfrom
ci-3692-inset-video
Open

ci-3692 inset vertical videos#176
leannecornish-ft wants to merge 1 commit into
mainfrom
ci-3692-inset-video

Conversation

@leannecornish-ft

@leannecornish-ft leannecornish-ft commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

So that vertical videos can be inset to the left or right, this PR adds "inset-left" | "inset-right" to ClipSetLayoutWidth

ticket: https://financialtimes.atlassian.net/browse/CI-3692

@leannecornish-ft leannecornish-ft requested review from a team as code owners June 18, 2026 10:56

@adgad adgad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to approve, am assuming someone in @Financial-Times/spark-team knows about the work needed there!

@todor-videv1 todor-videv1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks okay but there is a slight problem which it would introduce to one of the transformer libraries.

Take a look at

func toValidClipLayoutWidth(w string) layoutwidth {

func toValidClipLayoutWidth(w string) layoutwidth {
	switch w {
	case "in-line", "full-grid", "mid-grid":
		return layoutwidth(w)
	default:
		return "in-line"
	}
}

This has to be updated to feature the new values. Furthermore, we might need to add these two values here too, if there is the possibility to embed ClipSets in Articles with XML and use these values:
https://github.com/Financial-Times/body-validation-service/blob/f8afabf2a3bfe53c47622d4686770b78787bad50/src/main/resources/xsd/ft-types.xsd#L69

@leannecornish-ft

Copy link
Copy Markdown
Contributor Author

This has to be updated to feature the new values. Furthermore, we might need to add these two values here too, if there is the possibility to embed ClipSets in Articles with XML and use these values: https://github.com/Financial-Times/body-validation-service/blob/f8afabf2a3bfe53c47622d4686770b78787bad50/src/main/resources/xsd/ft-types.xsd#L69

I think there may be a possibility of it being used with XML, depending on how quickly the work is done on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants