Repository navigation
[FIX] bump cofhe-keys to the six-partner mainnet set, and test that every baked env is complete - #6
Merged
Conversation
…very baked env is complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tdx-signer pins
cofhe-keysat84028ad(2026-09-17). At that rev, mainnet partner slot 6 is still the placeholderFILL-ME-PARTNER-6. The keygen repo filled it one day later, in0e15839.The read path calls
partner_refs, which fails closed on a placeholder. So a zee-k image at this rev cannot boot withCOFHE_ENV=mainnet. The v1.0.2 pin291fcd71…was built at this rev.Nothing caught it, because no reader ever booted with
mainnet. The existing testconfig_env_mainnet_resolves_baked_partnerscheckspartners.len() == 6, and a placeholder still counts as one of the six.Changes
cofhe-keys→7f93823. That is keygenmain, and the exact commit of the keygen release imagesha256:f2ea9c48…. Writer and readers now bake the same partner map.Cargo.lockalso moveswindows-sys0.60.2 → 0.61.2 in some dependency lists. That package is Windows-only and does not reach the Linux image.every_baked_env_resolves_a_complete_partner_set. It runs the boot's ownpartner_refs(…, "zee-k", …)call for every baked env. A stale rev now fails CI, not a VM boot.Proof
84028adpartner set is incomplete: ["FILL-ME-PARTNER-6"] still is a placeholder7f93823After merge
The release build runs on push to
main, so it gives a boot-checked, attested image at the new rev. That digest can be the zee-k pin for KSH v1.0.3.