Repository navigation
ci: publish the image and the chart as Stashden, still tagging roxycloud-api - #249
Conversation
There was a problem hiding this comment.
The rename is consistent across the templates, CI and ferrflow.json. With nameOverride=roxycloud, the documented upgrade gives the same fullname and selector labels as the old chart, whatever the release name, so the Deployment selector stays the same.
Nit: the top-level README.md (lines 186-194, not in this diff) still points at deploy/helm/roxycloud, which this PR deletes, and tells people to helm install from oci://ghcr.io/ferrlabs/charts/roxycloud, which will stop getting releases. It should point at deploy/helm/stashden and charts/stashden, and link the new "Upgrading from the roxycloud chart" section.
Nit (unverified): the first push will create ghcr.io/ferrlabs/stashden-api and charts/stashden as new GHCR packages. Packages that Actions creates in an org default to private unless the org setting says otherwise. If that happens here, the chart's default image fails to pull with ImagePullBackOff for anyone not logged in. Check the visibility of both packages after the first release.
…oud-api Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
012317b to
2c138ba
Compare
|
README: the Kubernetes paragraph now moves to Visibility: agreed, and there is no API to change a container package's visibility, so |
Refs #245. Stacked on #248.
ghcr.io/ferrlabs/stashden-api, and the same digests are tagged inroxycloud-apitoo, throughmetadata-actiontaking both names.deploy/helm/stashden, published tooci://ghcr.io/ferrlabs/charts/stashden. Its name feeds every resource name and the Deployment's selector, which an upgrade cannot change, so a release installed from theroxycloudchart upgrades withnameOverride=roxycloud. The chart README documents it.Tested: rendering the old chart and the new one with
nameOverride=roxycloudfor a release namedroxycloudgives identical names and selectors for the Secret, the claim, the Service and the Deployment; without the override everything moves toroxycloud-stashden, which is what the README warns about.helm lint,kubeconformandactionlintpass.zizmorreports the sameartipackedandtemplate-injectionfindings inimage.ymlas on main; this does not add or fix them.