Skip to content

chore(deps): update node.js to v26 - #722

Open
ferrlabs-renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-docker-images
Open

ferrlabs-renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-docker-images

Conversation

@ferrlabs-renovate

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
docker.io/library/node (source) stage major 24-alpine → 26-alpine

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

Signed-off-by: ferrlabs-renovate[bot] <282300760+ferrlabs-renovate[bot]@users.noreply.github.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 24 to 26 in the dashboard stage of Dockerfile and the builder stage of site/Dockerfile. Nothing else changes.

Blocking (unverified, from upstream knowledge, not from a log): both files run corepack enable (Dockerfile:6, site/Dockerfile:7). As far as I know, Node stopped bundling Corepack from v25, and the official Docker images followed. If so, corepack: not found fails both stages, and pnpm is never installed. I could not confirm this: the "Build without publishing / Build & push" jobs for both images are still queued, so there is no log to read. Check those two jobs first. If they fail on corepack, the fix touches both Dockerfiles and the design is a choice: RUN npm install -g corepack@latest && corepack enable, or npm install -g pnpm@<version from packageManager>. I'd go with the first, since it keeps the packageManager field in package.json as the single source of truth for the pnpm version. If the builds pass, ignore this.

Compatibility: site/package.json has engines.node >=22.0.0, so 26 is allowed. The Angular 22, Vite 8 and TypeScript 6 toolchain should accept it, but I have not seen a build confirm that.

CI: nothing has failed yet. hadolint passes on both Dockerfiles. The rest is still queued or running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants