Skip to content

style(config): restore the blank line before the anonymous read comment - #571

Merged
BryanFRD merged 1 commit into
mainfrom
fix/review-nits-565-567
Oct 10, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
fix/review-nits-565-567

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Closes #570

Review nit from #565: the split dropped the blank line between LOOKUP_BUDGET and the comment opening anonymous_read. One line, no behaviour change.

The other two nits (#567's format suggestion, and the pub(super) helpers the tests reach) are not applied: the first would not pass cargo fmt --check since the macro arguments exceed rustfmt's 60-character call width, and the second would spread 391 lines of tests over three modules for a visibility that is already module-private.

@BryanFRD
BryanFRD enabled auto-merge (squash) October 10, 2026 16:02

@ferrfleet ferrfleet Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace only: one blank line separating LOOKUP_BUDGET from the next comment block. No behaviour change.

@BryanFRD
BryanFRD merged commit 59e9ce7 into main Oct 10, 2026
27 checks passed
@BryanFRD
BryanFRD deleted the fix/review-nits-565-567 branch October 10, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A comment in config/auth.rs reads as documenting the constant above it

1 participant