Skip to content

fix(chart): render GitHub App ids as integers - #561

Merged
BryanFRD merged 1 commit into
mainfrom
fix/review-followups-552
Oct 10, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
fix/review-followups-552

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Closes #560

CLI and collection tests and clippy pass.

@BryanFRD
BryanFRD enabled auto-merge (squash) October 10, 2026 10:25

@ferrfleet ferrfleet Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking.

  • Chart: Helm parses values.yaml integers as float64, so quote turned large app ids into 1.234567e+06. The lfsx.appId helper only casts float64 and lets --set int64 values and strings through unchanged, so it's safer than a blanket | int64, which would quietly turn a bad string into 0.
  • summary.rs: writeln! into the String is the idiomatic replacement for push_str(&format!(..)) (clippy format_push_string).
  • collect.rs: computes the prefix once. No change in behaviour.

@BryanFRD
BryanFRD merged commit d8d3d06 into main Oct 10, 2026
29 checks passed
@BryanFRD
BryanFRD deleted the fix/review-followups-552 branch October 10, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart renders a GitHub App id of a million or more in scientific notation

1 participant