Repository navigation
fix(cli): reach /health and /ready above a named forge's prefix in doctor - #519
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 3, 2026 09:56
![ferrfleet[bot]](https://avatars.githubusercontent.com/in/4354888?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks correct. The server mounts /health and /ready at the root and puts forges under /-/{name}/, so stripping one trailing /-/<name> segment matches what the server does.
Nit: Server::new trims trailing slashes, so the .../-/ case in a_base_without_a_forge_is_its_own_root can't come up as a real base (it would be .../-). It doesn't hurt, but it tests a case that never happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #518
lfsx doctornow asks/healthand/readyat the service root: a trailing/-/{forge}is taken off the base URL for those two, and kept for the repository checks. A deployment behind a path prefix (https://example.com/lfs/-/work) keeps its prefix. Unit-tested.