Skip to content

fix(server): title a named forge's repository page as acme/game (work) - #517

Merged
BryanFRD merged 1 commit into
mainfrom
fix/overview-page-forge-title
Oct 3, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
fix/overview-page-forge-title

Conversation

@BryanFRD

@BryanFRD BryanFRD commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Closes #516

The repository page now names a repository on a named forge as acme/game (work) in its title and heading instead of the storage key work~acme/game. The main forge's page is unchanged (acme/game). Tested.

@BryanFRD
BryanFRD enabled auto-merge (squash) October 3, 2026 09:25

@ferrfleet ferrfleet Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. title() keeps the org/repo page title for the default forge and adds (forge) for a named one, so work~ no longer shows up on the page. Leaving the title unescaped is fine because is_forge_name and is_well_formed only allow [A-Za-z0-9._-]. The new test covers both <title> and <h1>. Nothing blocking.

@BryanFRD
BryanFRD merged commit 6ea6fb7 into main Oct 3, 2026
27 checks passed
@BryanFRD
BryanFRD deleted the fix/overview-page-forge-title branch October 3, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repository page on a named forge is titled with the storage name

1 participant