Skip to content

A save can be overwritten by a refresh that was already reading the store #568

Closed

Description

@BryanFRD

The access refresh (every 30 s, and once at startup) reads the saved file from the store, then applies what it read. If a save from the dashboard lands between that read and the apply, the refresh puts the older settings back, and the dashboard has already answered "saved". The server keeps serving the old rules until the next tick, 30 s later, and with a bucket the read is a network round trip, so the window is real.

It surfaces in CI as forge_access::a_named_forge_takes_its_own_access_without_touching_the_main_one answering 200 where it expects 404, which has failed #565 and #567. It does not reproduce on Windows (60 of 60 runs pass).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions