Skip to content

fix(ci): repair YAML syntax in release benchmark step - #193

Merged
BryanFRD merged 3 commits into
mainfrom
feat/benchmark-in-release-notes
Mar 31, 2026
Merged

BryanFRD merged 3 commits into
mainfrom
feat/benchmark-in-release-notes

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Summary

  • Fix invalid YAML in CI workflow: the multi-line string assignment for benchmark release notes broke out of the run: | block scalar indentation
  • Replace with printf -v to build the string on a single line

Closes #191

Test plan

  • CI workflow file passes GitHub Actions YAML validation
  • Release job correctly appends benchmark results to release notes

@BryanFRD
BryanFRD merged commit ae49cde into main Mar 31, 2026
7 checks passed
@BryanFRD
BryanFRD deleted the feat/benchmark-in-release-notes branch March 31, 2026 18:39
@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 61c31a3 Previous: 89cb24c Ratio
commit_parsing/100 17465 ns/iter (± 413) 17460 ns/iter (± 106) 1.00
commit_parsing/1000 175132 ns/iter (± 756) 173746 ns/iter (± 2070) 1.01
commit_parsing/10000 1818677 ns/iter (± 10183) 1813481 ns/iter (± 15047) 1.00
changelog/build_50 8108 ns/iter (± 124) 8017 ns/iter (± 31) 1.01
changelog/build_500 69313 ns/iter (± 743) 70870 ns/iter (± 251) 0.98
version_files/toml_read 8459 ns/iter (± 83) 8508 ns/iter (± 316) 0.99
version_files/toml_write 145256 ns/iter (± 18816) 138019 ns/iter (± 20354) 1.05
version_files/json_read 5330 ns/iter (± 31) 5322 ns/iter (± 19) 1.00
version_files/json_write 138192 ns/iter (± 13494) 135709 ns/iter (± 9850) 1.02
version_files/xml_read 5113 ns/iter (± 27) 5122 ns/iter (± 24) 1.00
version_files/xml_write 190353 ns/iter (± 26282) 140127 ns/iter (± 44100) 1.36
version_files/gradle_read 4973 ns/iter (± 19) 5001 ns/iter (± 84) 0.99
version_files/gradle_write 141900 ns/iter (± 11415) 136640 ns/iter (± 7719) 1.04
config_loading/single 10392 ns/iter (± 376) 10329 ns/iter (± 75) 1.01
config_loading/mono_10 15597 ns/iter (± 142) 15729 ns/iter (± 103) 0.99
config_loading/mono_50 39837 ns/iter (± 777) 41353 ns/iter (± 2449) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 61c31a3 Previous: 89cb24c Ratio
version_files/xml_write 190353 ns/iter (± 26282) 140127 ns/iter (± 44100) 1.36

This comment was automatically generated by workflow using github-action-benchmark.

BryanFRD added a commit that referenced this pull request Apr 22, 2026
* feat(ci): include benchmark results in GitHub release notes

* fix(ci): repair YAML syntax in release benchmark step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include benchmark results in GitHub Release notes

1 participant