Repository navigation
fix(docker): recreate wasm stub before final build - #186
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 520ce61 | Previous: e52388a | Ratio |
|---|---|---|---|
commit_parsing/100 |
17615 ns/iter (± 102) |
17113 ns/iter (± 74) |
1.03 |
commit_parsing/1000 |
176067 ns/iter (± 1876) |
173504 ns/iter (± 4918) |
1.01 |
commit_parsing/10000 |
1817176 ns/iter (± 42469) |
1810549 ns/iter (± 39707) |
1.00 |
changelog/build_50 |
7854 ns/iter (± 21) |
8003 ns/iter (± 49) |
0.98 |
changelog/build_500 |
68109 ns/iter (± 281) |
69835 ns/iter (± 489) |
0.98 |
version_files/toml_read |
8462 ns/iter (± 143) |
8427 ns/iter (± 113) |
1.00 |
version_files/toml_write |
127290 ns/iter (± 8313) |
131965 ns/iter (± 8632) |
0.96 |
version_files/json_read |
5274 ns/iter (± 24) |
5306 ns/iter (± 25) |
0.99 |
version_files/json_write |
122594 ns/iter (± 7247) |
124620 ns/iter (± 11187) |
0.98 |
version_files/xml_read |
5157 ns/iter (± 36) |
5138 ns/iter (± 24) |
1.00 |
version_files/xml_write |
149716 ns/iter (± 16064) |
161203 ns/iter (± 20335) |
0.93 |
version_files/gradle_read |
5117 ns/iter (± 53) |
5029 ns/iter (± 29) |
1.02 |
version_files/gradle_write |
121691 ns/iter (± 6217) |
130173 ns/iter (± 11002) |
0.93 |
config_loading/single |
10290 ns/iter (± 59) |
10353 ns/iter (± 76) |
0.99 |
config_loading/mono_10 |
15570 ns/iter (± 155) |
15402 ns/iter (± 128) |
1.01 |
config_loading/mono_50 |
39276 ns/iter (± 785) |
39180 ns/iter (± 736) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
BryanFRD
added a commit
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ferrflow-wasm/srcdirectory is removed during the dependency cache step but not recreated before the final buildferrflow-wasm/src/lib.rsbeforecargo buildso the workspace resolves correctlyCloses #182