Skip to content

fix: add version_bump event and use typed EventType enum - #175

Merged
BryanFRD merged 4 commits into
mainfrom
fix/telemetry-enum
Mar 31, 2026
Merged

BryanFRD merged 4 commits into
mainfrom
fix/telemetry-enum

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Summary

  • Send version_bump telemetry event after each package version bump
  • Replace raw &str event types with a typed EventType enum in telemetry module
  • All existing call sites (check, release, init) updated to use the enum

Closes #173

@codecov

codecov Bot commented Mar 31, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/monorepo.rs 0.00% 8 Missing ⚠️
src/config.rs 0.00% 1 Missing ⚠️
src/telemetry.rs 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 5f54572 Previous: bf712e6 Ratio
commit_parsing/100 14805 ns/iter (± 96) 17534 ns/iter (± 203) 0.84
commit_parsing/1000 149456 ns/iter (± 2653) 176604 ns/iter (± 481) 0.85
commit_parsing/10000 1545564 ns/iter (± 21047) 1825101 ns/iter (± 18968) 0.85
changelog/build_50 7289 ns/iter (± 162) 8405 ns/iter (± 41) 0.87
changelog/build_500 62743 ns/iter (± 437) 72424 ns/iter (± 297) 0.87
version_files/toml_read 5512 ns/iter (± 40) 8413 ns/iter (± 162) 0.66
version_files/toml_write 78629 ns/iter (± 3892) 136023 ns/iter (± 8996) 0.58
version_files/json_read 2721 ns/iter (± 16) 5452 ns/iter (± 35) 0.50
version_files/json_write 106177 ns/iter (± 15363) 131127 ns/iter (± 10676) 0.81
version_files/xml_read 2360 ns/iter (± 20) 5188 ns/iter (± 28) 0.45
version_files/xml_write 77294 ns/iter (± 5477) 132765 ns/iter (± 12036) 0.58
version_files/gradle_read 2322 ns/iter (± 15) 5075 ns/iter (± 41) 0.46
version_files/gradle_write 78148 ns/iter (± 5118) 135528 ns/iter (± 16409) 0.58
config_loading/single 5167 ns/iter (± 26) 10408 ns/iter (± 321) 0.50
config_loading/mono_10 9802 ns/iter (± 88) 15519 ns/iter (± 258) 0.63
config_loading/mono_50 32526 ns/iter (± 500) 39300 ns/iter (± 329) 0.83

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 287de08 Previous: bf712e6 Ratio
version_files/toml_write 193585 ns/iter (± 27865) 136023 ns/iter (± 8996) 1.42
version_files/json_write 189044 ns/iter (± 34115) 131127 ns/iter (± 10676) 1.44
version_files/xml_write 176334 ns/iter (± 27382) 132765 ns/iter (± 12036) 1.33
version_files/gradle_write 179610 ns/iter (± 21154) 135528 ns/iter (± 16409) 1.33

This comment was automatically generated by workflow using github-action-benchmark.

@BryanFRD
BryanFRD merged commit 21f3fd9 into main Mar 31, 2026
11 checks passed
@BryanFRD
BryanFRD deleted the fix/telemetry-enum branch March 31, 2026 09:48
BryanFRD added a commit that referenced this pull request Apr 22, 2026
* fix: add version_bump event and use typed EventType enum

Closes #173

* fix(ci): rename github-token to ferrflow-token for benchmarks

* test: add telemetry module unit tests

* test: make telemetry tests thread-safe for tarpaulin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: missing version_bump telemetry event and stringly-typed event API

1 participant