Repository navigation
fix(cli): spell date and sequence strategies as configured in JSON output - #1293
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 7, 2026 06:46
This was referenced Oct 7, 2026
Contributor
There was a problem hiding this comment.
Looks correct. VersioningStrategy's Display impl already matches the serde kebab-case spelling (strategy_display_matches_the_config_spelling checks it), so to_string() fixes calvershortseq -> calver-short-seq in both places. The new test covers the date/seq, semver and forced branches.
Nit: the other format!("{x:?}").to_lowercase() calls in api_check.rs and plan_interactive.rs use BumpType, which has single-word variants and its own Display. They aren't wrong, but to_string() would be more consistent there too.
ferrflow Bot
added a commit
that referenced
this pull request
Oct 7, 2026
## [7.28.5] - 2026-10-07 ### Bug Fixes - fix(cli): spell date and sequence strategies as configured in JSON output (#1293)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1292
strategy_label(which feedsbump_typeincheck --jsonandrelease --json) and thestrategyfield ofwhy --jsonbuilt the name fromDebuglowercased, so acalver-short-seqpackage reportedcalvershortseq, a value the config rejects. Both now useVersioningStrategy'sDisplayfrom #1259, so they printcalver-short,calver-seqandcalver-short-seq.This changes JSON values that scripts may match on, which is why #1259 left it out. It ships as a
fix, not a major: the old spelling was never valid configuration and no documentation listed it.calver,sequential, the semver bump types andFERRFLOW_BUMP_TYPE(which comes fromBumpType, not this label) are unchanged.A new test pins
strategy_labelfor a hyphenated strategy, a semver bump and a forced version.