[OoT] fix draw layer suffix always being present - #723
Merged
Dragorn421 merged 2 commits intoAug 20, 2026
Conversation
Yanis002
approved these changes
Aug 17, 2026
|
DL exporting works as it should. I didn't try the other things like importing and exporting a scene though because I don't know how these files should be looking afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
OoT DList exporter
Fast64 allows setting draw layers by material. This splits the mesh by material on export, between opaque/translucent/overlay draw layers, writing out different display lists.
It was reported last year #602 that fast64 however was writing those different display lists using the same name, obviously causing errors on compile due to the duplicate symbol name.
The issue was fixed in #605 by appending a "_drawlayer_dl" suffix to the written draw layer display list
However there have been complaints since then about this behavior since you can't name a single-draw-layer-using mesh properly (like
gMyCubeDL) and have it be exported under that name, it would export as eggMyCubeDL_opaque_dlThis PR
This PR makes the suffix be omitted when a mesh is composed of a single draw layer. When several draw layers are present, it uses the draw layer suffixes.
Testing
I tested: