-
Notifications
You must be signed in to change notification settings - Fork 147
feat: add entity explosion resistance option #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Like4Schnitzel
wants to merge
2
commits into
FallingColors:main
Choose a base branch
from
Like4Schnitzel:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -23,6 +23,8 @@ public class ForgeHexConfig implements HexConfig.CommonConfigAccess { | |||||
| private static ForgeConfigSpec.IntValue trinketCooldown; | ||||||
| private static ForgeConfigSpec.IntValue artifactCooldown; | ||||||
|
|
||||||
| private static ForgeConfigSpec.IntValue entityExplosionResistance; | ||||||
|
|
||||||
| public ForgeHexConfig(ForgeConfigSpec.Builder builder) { | ||||||
| builder.push("Media Amounts"); | ||||||
| dustMediaAmount = builder.comment("How much media a single Amethyst Dust item is worth") | ||||||
|
|
@@ -43,6 +45,11 @@ public ForgeHexConfig(ForgeConfigSpec.Builder builder) { | |||||
| artifactCooldown = builder.comment("Cooldown in ticks of a artifact") | ||||||
| .defineInRange("artifactCooldown", DEFAULT_ARTIFACT_COOLDOWN, 0, Integer.MAX_VALUE); | ||||||
| builder.pop(); | ||||||
|
|
||||||
| builder.push("Misc"); | ||||||
| entityExplosionResistance = builder.comment("How much entities should resist explosion damage, where the reduction is Value times 20%") | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: grammar. also see main comment
Suggested change
|
||||||
| .defineInRange("entityExplosionResistance", DEFAULT_ENTITY_EXPLOSION_RESISTANCE, 0, 5); | ||||||
| builder.pop(); | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
|
|
@@ -80,6 +87,11 @@ public int artifactCooldown() { | |||||
| return artifactCooldown.get(); | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
| public int entityExplosionResistance() { | ||||||
| return entityExplosionResistance.get(); | ||||||
| } | ||||||
|
|
||||||
| public static class Client implements HexConfig.ClientConfigAccess { | ||||||
| private static ForgeConfigSpec.BooleanValue ctrlTogglesOffStrokeOrder; | ||||||
| private static ForgeConfigSpec.BooleanValue disableInworldScrolling; | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing lang file entries for config options on fabric