Skip to content

[CP Staging] Rename saved search when re-saving #88133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 4 commits into from
Apr 17, 2026
+3 −9
Merged

[CP Staging] Rename saved search when re-saving #88133

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99b36de
allow renaming
JS00001 Apr 16, 2026
de14725
fix lint
JS00001 Apr 16, 2026
560771a
trim name and fallback to the input query
JS00001 Apr 16, 2026
55d72c8
move name trim down
JS00001 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/pages/Search/SearchSavePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,25 +83,20 @@ function FilterValue({filterKey, value}: FilterValueWithKeyProps) {
function SearchSavePage() {
const styles = useThemeStyles();
const {translate, localeCompare} = useLocalize();
const [savedSearches] = useOnyx(ONYXKEYS.SAVED_SEARCHES);
const [searchAdvancedFiltersForm = getEmptyObject<Partial<SearchAdvancedFiltersForm>>()] = useOnyx(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM);
const [name, setName] = useState('');

const {currentSearchQueryJSON} = useSearchStateContext();

const onSaveSearch = () => {
const savedSearchKeys = Object.keys(savedSearches ?? {});
if (!currentSearchQueryJSON || (savedSearches && savedSearchKeys.includes(String(currentSearchQueryJSON.hash)))) {
// If the search is already saved, we only display the results as we don't need to save it.
const newName = name?.trim() || currentSearchQueryJSON?.inputQuery;
Comment thread
JS00001 marked this conversation as resolved.
Outdated
Comment thread
JS00001 marked this conversation as resolved.
Outdated

if (!currentSearchQueryJSON) {
Navigation.goBack();
return;
}

if (name) {
saveSearch({queryJSON: currentSearchQueryJSON, newName: name});
} else {
saveSearch({queryJSON: currentSearchQueryJSON});
}
saveSearch({queryJSON: currentSearchQueryJSON, newName});
Navigation.goBack();
};

Expand Down
Loading