fix: support application versions longer than 50 characters - #700
Open
Manny7717 wants to merge 1 commit into
Open
fix: support application versions longer than 50 characters#700Manny7717 wants to merge 1 commit into
Manny7717 wants to merge 1 commit into
Conversation
Version names longer than 50 characters (e.g. the Play Store value 'flavorpreviewRelease-10.0.0.191210.1822.126-RELEASE') could not be stored, aborting analysis right after 'Tracker analysis: success'. Increase Application.version to 100 characters, matching version_code, and surface the full version string as a tooltip in the reports list (already truncated at 20 chars). Closes Exodus-Privacy#300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #300.
Application version names longer than 50 characters (e.g. the Play Store value
flavorpreviewRelease-10.0.0.191210.1822.126-RELEASE) could not be stored in theApplication.versionfield, which aborted the analysis right after the "Tracker analysis: success" message.This PR:
Application.versiontomax_length=100(matchingversion_code, per the discussion in Handle app with version name with > 50 characters #300)How it was tested
DataError: value too long) and passes with the fixpython manage.py test, settingsexodus.settings.dev, PostgreSQL 15 — same as CI)flake8 exodus/cleandjhtml --checkclean on the modified templatemakemigrations --checkreports no driftLimitations
No changes to the analysis pipeline itself; the analysis was already made to fail cleanly in #300's earlier work — this fixes storage of the long value so analysis can complete.