Reduced regression features - #82
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a configurable “reduced” feature set for stereo regression training, allowing training to use a stable, explicitly enumerated subset of flattened columns (while keeping the default “extended” behavior unchanged).
Changes:
- Add
regression_feature_columns(..., profile=...)withextendedvsreducedselection and strict required-column validation for the reduced profile. - Wire
--feature_profile {extended,reduced}into stereo training configuration and update regression training to use the selected profile. - Add tests and README documentation for the reduced regression feature profile; adjust default stereo hyperparameters.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_regression_contracts.py | Adds a contract test ensuring the reduced profile selects the exact requested regression columns. |
| tests/test_features.py | Adds tests pinning the reduced regression column list and verifying missing-column errors. |
| tests/test_config.py | Verifies --feature_profile reduced is parsed for stereo training. |
| src/eventdisplay_ml/models.py | Switches regression training feature selection to regression_feature_columns based on feature_profile. |
| src/eventdisplay_ml/features.py | Introduces regression_feature_columns with extended/reduced profiles and required-column checks. |
| src/eventdisplay_ml/configs/default_hyperparameters_stereo.json | Tweaks default stereo regression hyperparameters (max_depth, min_child_weight). |
| src/eventdisplay_ml/config.py | Adds the stereo-only CLI flag --feature_profile and logs the chosen profile. |
| README.md | Documents the reduced regression feature profile and provides an example command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
GernotMaier
marked this pull request as ready for review
August 28, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.