Skip to content

#2321 [Trigger] add: trigger for unlink question and group #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evarisk-kilyan wants to merge 1 commit into
base: develop
Choose a base branch
from
+15 −11
Open

#2321 [Trigger] add: trigger for unlink question and group #2322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/triggers/interface_99_modDigiQuali_DigiQualiTriggers.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function runTrigger($action, $object, User $user, Translate $langs, Conf

$objects = ['QUESTION', 'SHEET', 'CONTROL', 'SURVEY', 'QUESTIONGROUP'];
$triggerTypes = ['CREATE', 'MODIFY', 'DELETE', 'VALIDATE', 'LOCK', 'ARCHIVE'];
$extraActions = ['CONTROL_UNVALIDATE', 'SURVEY_UNVALIDATE', 'CONTROL_SENTBYMAIL', 'SURVEY_SENTBYMAIL', 'CONTROL_SAVEANSWER', 'SURVEY_SAVEANSWER', 'SHEET_ADDQUESTION', 'SHEET_ADDQUESTIONGROUP', 'QUESTIONGROUP_ADDQUESTION'];
$extraActions = ['CONTROL_UNVALIDATE', 'SURVEY_UNVALIDATE', 'CONTROL_SENTBYMAIL', 'SURVEY_SENTBYMAIL', 'CONTROL_SAVEANSWER', 'SURVEY_SAVEANSWER', 'SHEET_ADDQUESTION', 'SHEET_ADDQUESTIONGROUP', 'QUESTIONGROUP_ADDQUESTION', 'SHEET_UNLINKQUESTION', 'SHEET_UNLINKQUESTIONGROUP'];
Copy link
Copy Markdown
Contributor

@nicolas-eoxia nicolas-eoxia Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alors j'ai un doute mais normalement ce type de trigger a des informations complémentaires et je pense pas que dans la fonction getTriggerDescription il y soit


$actions = array_merge(
array_merge(...array_map(fn($s) => array_map(fn($p) => "{$p}_{$s}", $objects), $triggerTypes)),
Expand Down
22 changes: 12 additions & 10 deletions langs/fr_FR/digiquali.lang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,18 @@ NoQuestion = Aucune question
#

# Data - Donnée
QuestionGroup = Groupe de questions
Questiongroup = Groupe de questions
QuestionGroups = Groupes de questions
NewQuestionGroup = Nouveau groupe de questions
QuestiongroupList = Liste des groupes de questions
RemoveQuestionFromGroup = Question retirée du groupe
RemoveQuestionGroupLink = Groupe de questions retiré du modèle :
TheQuestiongroup = groupe de questions
ObjectAddquestionTrigger = Question ajoutée
ObjectAddquestiongroupTrigger = Groupe de questions ajouté
QuestionGroup = Groupe de questions
Questiongroup = Groupe de questions
QuestionGroups = Groupes de questions
NewQuestionGroup = Nouveau groupe de questions
QuestiongroupList = Liste des groupes de questions
RemoveQuestionFromGroup = Question retirée du groupe
RemoveQuestionGroupLink = Groupe de questions retiré du modèle :
TheQuestiongroup = groupe de questions
ObjectAddquestionTrigger = Question ajoutée
ObjectAddquestiongroupTrigger = Groupe de questions ajouté
ObjectUnlinkquestionTrigger = Question retiré
ObjectUnlinkquestiongroupTrigger = Groupe de questions retiré
Comment on lines +170 to +171
Copy link
Copy Markdown
Contributor

@nicolas-eoxia nicolas-eoxia Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il me semble qu'il existe déjà un trad générique pour ça dans saturne et si c'est pas le cas il serait intéressant de la rajouter



#
Expand Down
2 changes: 2 additions & 0 deletions view/sheet/sheet_card.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@
}

$question->deleteObjectLinked($sourceId, $sourceType, $questionId, 'digiquali_question');
Copy link
Copy Markdown
Contributor

@nicolas-eoxia nicolas-eoxia Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai vérifié et il existe déjà un trigger dans cette fonction donc je vois pas de raison de refaire un trigger

$object->call_trigger('SHEET_UNLINKQUESTION', $user);

setEventMessages($langs->trans('removeQuestionLink') . ' ' . $question->ref, array());

Expand All @@ -211,6 +212,7 @@
$sourceElementType = $questionGroup->element;
}
$questionGroup->deleteObjectLinked($parentGroupId, 'digiquali_' . $sourceElementType, $questionGroup->id, 'digiquali_questiongroup');
$object->call_trigger('SHEET_UNLINKQUESTIONGROUP', $user);

setEventMessages($langs->trans('RemoveQuestionGroupLink') . ' ' . $questionGroup->ref, array());

Expand Down