Repository navigation
[codex] Add ForeSITE pkgdown brand - #93
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The sync workflow trusts mutable executable code with write permissions and its generated pull requests cannot trigger existing CI checks.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds the shared ForeSITE brand to the pkgdown site and establishes automated synchronization.
Changes:
- Adds canonical branding assets and pkgdown configuration.
- Adds required website dependencies and funding acknowledgement.
- Adds a weekly/manual brand-sync workflow.
| File | Description |
|---|---|
_pkgdown.yml |
Enables branding, navbar, and footer. |
DESCRIPTION |
Declares the branding dependency. |
NEWS.md |
Records the rollout. |
.github/workflows/pkgdown.yaml |
Installs brand.yml. |
.github/workflows/sync-foresite-brand.yml |
Calls the reusable sync workflow. |
pkgdown/brand/_brand.yml |
Defines ForeSITE branding. |
pkgdown/brand/assets/logos/foresite-black.png |
Adds black logo. |
pkgdown/brand/assets/logos/foresite-crimson.png |
Adds crimson logo. |
pkgdown/brand/assets/logos/foresite-gold.png |
Adds gold logo. |
pkgdown/brand/assets/logos/foresite-icon.png |
Adds icon logo. |
pkgdown/brand/assets/logos/foresite-primary.png |
Adds primary logo. |
pkgdown/brand/assets/logos/foresite-secondary.png |
Adds secondary logo. |
pkgdown/brand/assets/logos/foresite-white.png |
Adds white logo. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| jobs: | ||
| sync: | ||
| uses: EpiForeSITE/rbranding/.github/workflows/sync-foresite-brand.yml@main |
|
|
||
| jobs: | ||
| sync: | ||
| uses: EpiForeSITE/rbranding/.github/workflows/sync-foresite-brand.yml@main |
Member
Author
|
@damontoth, this is 100% branding, which does not affect package functionality. I will go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Related to EpiForeSITE/rbranding#77. This is a downstream rollout of the
canonical ForeSITE pkgdown brand.
The package had no local copy of the shared brand, so its documentation site
could not inherit the ForeSITE colors, typography, navigation treatment, logo
rules, or standard funding acknowledgement. This PR copies the canonical
_brand.ymland seven logo assets intopkgdown/brand/, points pkgdown at thebrand, and adds the shared navbar and footer settings while preserving the
package-specific site configuration.
It also declares
brand.ymlas a website dependency, installs it in thepkgdown workflow, records the rollout in NEWS, and adds a weekly/manual caller
for the reusable brand-sync workflow. The caller follows
main; it will open apackage-local pull request whenever the canonical brand changes. The reusable
workflow is supplied by EpiForeSITE/rbranding#79 and should merge first.
Validation
git diff --check.their pkgdown metadata reported only pre-existing URL warnings.