fix(results): prefer project mappings for registered projects#1297
Open
christso wants to merge 1 commit into
Open
fix(results): prefer project mappings for registered projects#1297christso wants to merge 1 commit into
christso wants to merge 1 commit into
Conversation
Deploying agentv with
|
| Latest commit: |
1fc5a6f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7cc46cbe.agentv.pages.dev |
| Branch Preview URL: | https://feature-agentv-results-by-pr.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.agentv/config.yamlno longer blocks globalresults_by_projectmappings from being attached.resultsis still used when the registered project id has no global mapping, and top-level globalresultsremains the fallback when no project-local config exists.Why
The non-Docker Dashboard deployment writes machine-local result repo settings to
$AGENTV_HOME/config.yaml. A checked-in project-local top-levelresultsblock could previously override that machine-local project mapping, causing/api/projects/:projectId/remote/statusto report the wrong clone path andauto_push: false.Verification
bun installbun test packages/core/test/evaluation/loaders/config-loader.test.tsbun --filter @agentv/eval build && bun --filter @agentv/core buildbun test apps/cli/test/commands/results/serve.test.tsbun --filter @agentv/core typecheckbun --filter agentv typecheck