Access more homology metadata via multi packed file#1168
Open
twalsh-ebi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to mitigate issues with a long-running database query — particularly affecting Ensembl Fungi — by avoiding calling the API method(s) triggering it.
It adds method
ConfigPacker::_build_gene_tree_stats_mlssto populateGENE_TREE_STATS_MLSS_IDS, which is used inEnsEMBL::Web::Document::HTML::Compara::GeneTrees::format_gene_tree_statsto fetch the species tree of a gene-tree collection without going through itsMethodLinkSpeciesSet.It adds method
ConfigPacker::_build_homology_mlss_tagsto populateHOMOLOGY_MLSS_TAGS, which is used inEnsembl::Web::Object::Gene::fetch_homology_species_hashto fetch GOC/WGA thresholds with instantiating aMethodLinkSpeciesSetobject.Views affected
These changes would affect respectively gene-tree stats views and homology pages.
Examples are given below of test and baseline sandbox pages, all in sandbox sites in which calls to Compara method SpeciesSetAdaptor::_left_join throw an error. The error is not thrown on the test pages because
SpeciesSetAdaptor::_left_joinis not being called.Possible complications
This change would require repacking of all
MULTI.db.packedfiles.Without repacking:
format_gene_tree_statswould revert to previous behaviour, selecting a species tree dynamically;fetch_homology_species_hashwould return undefined GOC/WGA thresholds.Merge conflicts
None detected.
Related JIRA Issues (EBI developers only)